Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Johannes Weiner <[EMAIL PROTECTED]> wrote: > On Thu, Oct 11, 2007 at 08:17:02AM +0200, Vegard Nossum wrote: > > This makes sure printk format strings are string literals containing no > > more than a single line. > > Perhaps you should write _why_ one-line printk()s are even needed, wi

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Johannes Weiner
Hi, On Thu, Oct 11, 2007 at 08:17:02AM +0200, Vegard Nossum wrote: > This makes sure printk format strings are string literals containing no > more than a single line. Perhaps you should write _why_ one-line printk()s are even needed, with profound reasons instead of constantly talking about myst

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Randy Dunlap
On Thu, 11 Oct 2007 18:09:47 +0200 Vegard Nossum wrote: > On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > On Thu, 11 Oct 2007 17:55:16 +0200 Vegard Nossum wrote: > > > > > On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote:

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Thu, 11 Oct 2007 17:55:16 +0200 Vegard Nossum wrote: > > > On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: > > > > > > > This makes sure printk format strings are string lite

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Randy Dunlap
On Thu, 11 Oct 2007 17:55:16 +0200 Vegard Nossum wrote: > On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: > > > > > This makes sure printk format strings are string literals containing no > > > more than a single line. > > > > Each p

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: > > > This makes sure printk format strings are string literals containing no > > more than a single line. > > Each patch needs justification (unless it is blatantly obvious). > > > > Sign

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Randy Dunlap
On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: > This makes sure printk format strings are string literals containing no > more than a single line. Each patch needs justification (unless it is blatantly obvious). > Signed-off-by: Vegard Nossum <[EMAIL PROTECTED]> > --- > init/calibrat

[PATCH] init: Fix printk format strings

2007-10-10 Thread Vegard Nossum
This makes sure printk format strings are string literals containing no more than a single line. Signed-off-by: Vegard Nossum <[EMAIL PROTECTED]> --- init/calibrate.c|4 +++- init/do_mounts_initrd.c |5 - init/main.c |2 +- 3 files changed, 8 insertions(+), 3