Re: [PATCH] infiniband: remove WARN that is not kernel bug

2016-11-21 Thread Dmitry Vyukov
On Sat, Nov 19, 2016 at 7:57 PM, Jason Gunthorpe wrote: > On Fri, Nov 18, 2016 at 09:22:42PM -0500, valdis.kletni...@vt.edu wrote: >> On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said: >> > WARNINGs mean kernel bugs. >> > The one in ucma_write() points to user programming error >> > or a mali

Re: [PATCH] infiniband: remove WARN that is not kernel bug

2016-11-19 Thread Jason Gunthorpe
On Fri, Nov 18, 2016 at 09:22:42PM -0500, valdis.kletni...@vt.edu wrote: > On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said: > > WARNINGs mean kernel bugs. > > The one in ucma_write() points to user programming error > > or a malicious attempt. This is not a kernel bug, remove it. > > > -

Re: [PATCH] infiniband: remove WARN that is not kernel bug

2016-11-18 Thread Valdis . Kletnieks
On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said: > WARNINGs mean kernel bugs. > The one in ucma_write() points to user programming error > or a malicious attempt. This is not a kernel bug, remove it. > - if (WARN_ON_ONCE(!ib_safe_file_access(filp))) > + if (!ib_safe_file_access(filp

[PATCH] infiniband: remove WARN that is not kernel bug

2016-11-18 Thread Dmitry Vyukov
WARNINGs mean kernel bugs. The one in ucma_write() points to user programming error or a malicious attempt. This is not a kernel bug, remove it. BUG/WARNs that are not kernel bugs hinder automated testing effots. Signed-off-by: Dmitry Vyukov Cc: Doug Ledford Cc: Sean Hefty Cc: Hal Rosenstock