Re: [PATCH] imx-drm: Fix probe failure

2013-08-28 Thread Fabio Estevam
On Wed, Aug 28, 2013 at 5:34 PM, Sascha Hauer wrote: > On Wed, Aug 28, 2013 at 05:10:16PM -0300, Fabio Estevam wrote: >> On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer wrote: >> >> > Do the open/close callbacks work? >> >> The 'open' callback maps to the generic 'drm_open', so we cannot use it. >

Re: [PATCH] imx-drm: Fix probe failure

2013-08-28 Thread Sascha Hauer
On Wed, Aug 28, 2013 at 05:10:16PM -0300, Fabio Estevam wrote: > On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer wrote: > > > Do the open/close callbacks work? > > The 'open' callback maps to the generic 'drm_open', so we cannot use it. We could replace this, but... > > Shouldn't we rely on the

Re: [PATCH] imx-drm: Fix probe failure

2013-08-28 Thread Fabio Estevam
On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer wrote: > Do the open/close callbacks work? The 'open' callback maps to the generic 'drm_open', so we cannot use it. Shouldn't we rely on the refcount done by the drm core instead of doing this manually in imx-drm? -- To unsubscribe from this list: s

Re: [PATCH] imx-drm: Fix probe failure

2013-08-28 Thread Sascha Hauer
On Wed, Aug 28, 2013 at 11:39:11AM -0300, Fabio Estevam wrote: > On Wed, Aug 28, 2013 at 2:27 AM, Sascha Hauer wrote: > > > Nack. We need the references to prevent that encoders/connectors are > > (de)registered while the device is active. Simply dropping this code is > > no solution. > > Any su

Re: [PATCH] imx-drm: Fix probe failure

2013-08-28 Thread Fabio Estevam
On Wed, Aug 28, 2013 at 2:27 AM, Sascha Hauer wrote: > Nack. We need the references to prevent that encoders/connectors are > (de)registered while the device is active. Simply dropping this code is > no solution. Any suggestions about a proper way of handling this? After b5dc0d10, imx_drm_devic

Re: [PATCH] imx-drm: Fix probe failure

2013-08-27 Thread Sascha Hauer
On Tue, Aug 27, 2013 at 11:32:43PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe > failure is seen: > > [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). > [drm] No driver support for vblank timestamp

Re: [PATCH] imx-drm: Fix probe failure

2013-08-27 Thread Fabio Estevam
Hi Greg, On Wed, Aug 28, 2013 at 12:11 AM, Greg KH wrote: > On Tue, Aug 27, 2013 at 11:32:43PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe >> failure is seen: > > I don't have that commit in any tree I cont

Re: [PATCH] imx-drm: Fix probe failure

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 11:32:43PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe > failure is seen: I don't have that commit in any tree I control, so I can't apply this patch. What tree is this commit in? tha

[PATCH] imx-drm: Fix probe failure

2013-08-27 Thread Fabio Estevam
From: Fabio Estevam Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe failure is seen: [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [drm] No driver support for vblank timestamp query. [drm] Initialized imx-drm 1.0.0 20120507 on minor 0 imx-ldb ldb.10: ad