Re: [PATCH] iio: light: add driver support for MAX44009

2019-01-21 Thread Rob Herring
On Wed, Jan 16, 2019 at 10:56:23PM -0800, Robert Eshleman wrote: > The MAX44009 is a low-power ambient light sensor from Maxim Integrated. > It differs from the MAX44000 in that it doesn't have proximity sensing and > that > it requires far less current (1 micro-amp vs 5 micro-amps). The register

Re: [PATCH] iio: light: add driver support for MAX44009

2019-01-21 Thread Jonathan Cameron
On Sun, 20 Jan 2019 22:39:14 -0800 Robert Eshleman wrote: > On Sat, Jan 19, 2019 at 08:41:46PM +0100, Peter Meerwald-Stadler wrote: > > Hey Jonathon and Peter, > > First, thank you for the constructive and in-depth feedback. > > I have a question below regarding a section of code that will nee

Re: [PATCH] iio: light: add driver support for MAX44009

2019-01-20 Thread Robert Eshleman
On Sat, Jan 19, 2019 at 08:41:46PM +0100, Peter Meerwald-Stadler wrote: Hey Jonathon and Peter, First, thank you for the constructive and in-depth feedback. I have a question below regarding a section of code that will need to be protected against a race condition if future features are added.

Re: [PATCH] iio: light: add driver support for MAX44009

2019-01-19 Thread Peter Meerwald-Stadler
On Sat, 19 Jan 2019, Jonathan Cameron wrote: some more comments from my side below... > On Wed, 16 Jan 2019 22:56:23 -0800 > Robert Eshleman wrote: > > Hi Robert, > > Note I review drivers backwards, so comments may make more sense that > way around. > > > The MAX44009 is a low-power ambient

Re: [PATCH] iio: light: add driver support for MAX44009

2019-01-19 Thread Jonathan Cameron
On Wed, 16 Jan 2019 22:56:23 -0800 Robert Eshleman wrote: Hi Robert, Note I review drivers backwards, so comments may make more sense that way around. > The MAX44009 is a low-power ambient light sensor from Maxim Integrated. > It differs from the MAX44000 in that it doesn't have proximity sensi

[PATCH] iio: light: add driver support for MAX44009

2019-01-16 Thread Robert Eshleman
The MAX44009 is a low-power ambient light sensor from Maxim Integrated. It differs from the MAX44000 in that it doesn't have proximity sensing and that it requires far less current (1 micro-amp vs 5 micro-amps). The register mapping and feature set between the two are different enough to require a