Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-17 Thread Dean Nelson
On Wed, May 02, 2007 at 09:44:11AM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > On Thu, Apr 26, 2007 at 01:11:15PM -0600, Eric W. Biederman wrote: > >> > >> Ok.Because of the module unloading issue, and because we don't have > >> a lot of these threads running a

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-02 Thread Eric W. Biederman
Dean Nelson <[EMAIL PROTECTED]> writes: > On Mon, Apr 30, 2007 at 10:22:30AM -0500, Dean Nelson wrote: >> On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: >> > Dean Nelson <[EMAIL PROTECTED]> writes: >> > >> > > Taking it one step further, if you added the notion of a thread poo

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-02 Thread Dean Nelson
On Mon, Apr 30, 2007 at 10:22:30AM -0500, Dean Nelson wrote: > On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: > > Dean Nelson <[EMAIL PROTECTED]> writes: > > > > > Taking it one step further, if you added the notion of a thread pool, > > > where upon exit, a thread isn't destro

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-30 Thread Dean Nelson
On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > >> Dean Nelson <[EMAIL PROTECTED]> writes: > >> > > >> > XPC is in need of threads that can block indefinitely, wh

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Eric W. Biederman
Dean Nelson <[EMAIL PROTECTED]> writes: > On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: >> Dean Nelson <[EMAIL PROTECTED]> writes: >> > >> > Christoph is correct in that XPC has a single thread that exists throughout >> > its lifetime, another set of threads that exist for the

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Dean Nelson
On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > > Christoph is correct in that XPC has a single thread that exists throughout > > its lifetime, another set of threads that exist for the time that active > > contact with other XPCs r

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Eric W. Biederman
Dean Nelson <[EMAIL PROTECTED]> writes: > > Christoph is correct in that XPC has a single thread that exists throughout > its lifetime, another set of threads that exist for the time that active > contact with other XPCs running on other SGI system partitions exists, and > finally there is a pool o

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Dean Nelson
On Thu, Apr 19, 2007 at 04:51:03PM -0700, Andrew Morton wrote: > Another driver which should be fully converted to the kthread API: > kthread_stop() and kthread_should_stop(). > > And according to my logs, this driver was added to the tree more than > a year _after_ the kthread interface was made

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-26 Thread Dean Nelson
On Thu, Apr 19, 2007 at 01:58:44AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> > > This patch starts the xpc kernel threads using kthread_run > not a combination of kernel_thread and daemonize. Resuling > in slightly simpler and more maintainable code. > > Cc: J

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-23 Thread Russ Anderson
Jes Sorensen wrote: > > Russ/Dean/Robin - could one of you provide some feedback to this one > please. Dean's on vacation for a couple days and will test it when he gets back. -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc [EMAIL PROTECTED] - To unsubsc

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-23 Thread Eric W. Biederman
Jes Sorensen <[EMAIL PROTECTED]> writes: > > Like with the previous patch from Eric, I'm CC'ing the correct people > for this patch (forwarded it in a seperate email). CC'ing irrelevant > lists such as containers@ and not linux-ia64@ makes it somewhat > difficult to get proper reviews of these thi

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-23 Thread Jes Sorensen
Christoph Hellwig wrote: On Thu, Apr 19, 2007 at 01:58:44AM -0600, Eric W. Biederman wrote: From: Eric W. Biederman <[EMAIL PROTECTED]> This patch starts the xpc kernel threads using kthread_run not a combination of kernel_thread and daemonize. Resuling in slightly simpler and more maintainabl

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-22 Thread Christoph Hellwig
On Thu, Apr 19, 2007 at 01:58:44AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> > > This patch starts the xpc kernel threads using kthread_run > not a combination of kernel_thread and daemonize. Resuling > in slightly simpler and more maintainable code. This driv

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-21 Thread Eric W. Biederman
Robin Holt <[EMAIL PROTECTED]> writes: > I think this was originally coded with daemonize to avoid issues with > reaping children. Dean Nelson can correct me if I am wrong. I assume > this patch is going in as part of the set which will make these threads > clear themselves from the children lis

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-20 Thread Robin Holt
On Fri, Apr 20, 2007 at 08:23:39AM +0200, Jes Sorensen wrote: > Andrew Morton wrote: > >Another driver which should be fully converted to the kthread API: > >kthread_stop() and kthread_should_stop(). > > > >And according to my logs, this driver was added to the tree more than > >a year _after_ the

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-19 Thread Jes Sorensen
Andrew Morton wrote: Another driver which should be fully converted to the kthread API: kthread_stop() and kthread_should_stop(). And according to my logs, this driver was added to the tree more than a year _after_ the kthread interface was made available. This isn't good. Andrew, Per my pre

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 01:58:44 -0600 "Eric W. Biederman" <[EMAIL PROTECTED]> wrote: > > This patch starts the xpc kernel threads using kthread_run > not a combination of kernel_thread and daemonize. Resuling > in slightly simpler and more maintainable code. > > Cc: Jes Sorensen <[EMAIL PROTECTED]

[Fwd: [PATCH] ia64 sn xpc: Convert to use kthread API.]

2007-04-19 Thread Jes Sorensen
Russ, Robin, Any objections to this patch? Eric, please send such patches to the appropriate list, it's in ia64 file after all. Thanks, Jes --- Begin Message --- From: Eric W. Biederman <[EMAIL PROTECTED]> This patch starts the xpc kernel threads using kthread_run not a combination of kernel_

[PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> This patch starts the xpc kernel threads using kthread_run not a combination of kernel_thread and daemonize. Resuling in slightly simpler and more maintainable code. Cc: Jes Sorensen <[EMAIL PROTECTED]> Cc: Tony Luck <[EMAIL PROTECTED]> Signed-off-by:

[PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch starts the xpc kernel threads using kthread_run not a combination of kernel_thread and daemonize. Resuling in slightly simpler and more maintainable code. Cc: Jes Sorensen <[EMAIL PROTECTED]> Cc: Tony Luck <[EMAIL PROTECTED]> Sign