Re: [PATCH] i386 boottime for_each_cpu broken

2005-09-09 Thread Zwane Mwaikambo
On Fri, 9 Sep 2005, Andrew Morton wrote: > > static void __init MP_processor_info (struct mpc_config_processor *m) > > { > > - int ver, apicid; > > + int ver, apicid, cpu, found_bsp = 0; > > physid_mask_t tmp; > > > > if (!(m->mpc_cpuflag & CPU_ENABLED)) > > @@ -181,6 +181,7 @@

Re: [PATCH] i386 boottime for_each_cpu broken

2005-09-09 Thread Andrew Morton
05 Sep 2005 14:06:13 -0700 > > [PATCH] i386 boottime for_each_cpu broken > > for_each_cpu walks through all processors in cpu_possible_map, which is > defined as cpu_callout_map on i386 and isn't initialised until all > processors have been booted. This breaks things which do for_e

Re: [PATCH] i386 boottime for_each_cpu broken

2005-08-11 Thread Zwane Mwaikambo
Hello Bharata, On Thu, 11 Aug 2005, Bharata B Rao wrote: > I don't know the context of your work here, but a couple of > observations. > > Since you populate cpu_possible_map with NR_CPUS, alloc_percpu() > would end up allocating for all NR_CPUS. Wouldn't you have achieved > the same thing by

Re: [PATCH] i386 boottime for_each_cpu broken

2005-08-11 Thread Zwane Mwaikambo
On Thu, 11 Aug 2005, Andi Kleen wrote: > On Wed, Aug 10, 2005 at 10:59:28PM -0600, Zwane Mwaikambo wrote: > > for_each_cpu walks through all processors in cpu_possible_map, which is > > defined as cpu_callout_map on i386 and isn't initialised until all > > processors have been booted. This break

Re: [PATCH] i386 boottime for_each_cpu broken

2005-08-11 Thread Andi Kleen
On Wed, Aug 10, 2005 at 10:59:28PM -0600, Zwane Mwaikambo wrote: > for_each_cpu walks through all processors in cpu_possible_map, which is > defined as cpu_callout_map on i386 and isn't initialised until all > processors have been booted. This breaks things which do for_each_cpu > iterations ear

Re: [PATCH] i386 boottime for_each_cpu broken

2005-08-10 Thread Bharata B Rao
On Thu, Aug 11, 2005 at 04:54:44AM +, Zwane Mwaikambo wrote: > for_each_cpu walks through all processors in cpu_possible_map, which is > defined as cpu_callout_map on i386 and isn't initialised until all > processors have been booted. This breaks things which do for_each_cpu > iterations ear

[PATCH] i386 boottime for_each_cpu broken

2005-08-10 Thread Zwane Mwaikambo
for_each_cpu walks through all processors in cpu_possible_map, which is defined as cpu_callout_map on i386 and isn't initialised until all processors have been booted. This breaks things which do for_each_cpu iterations early during boot. So, define cpu_possible_map as a bitmap with NR_CPUS bit