Re: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall

2014-09-22 Thread Wolfram Sang
Hi, > In general you are correct. You can get by with lots of probe > deferrals. I don't personally know of any case where things are > broken with the current code, but it's really nice to avoid the > deferrals if possible. Yes, we all want proper dependencies and ordering, yet deferred probin

Re: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall

2014-09-22 Thread Doug Anderson
Max, On Mon, Sep 22, 2014 at 9:05 AM, Max Schwarz wrote: > Hi Chris, > > Am Montag, 22. September 2014, 15:24:35 schrieb Chris Zhong: >> Some device using this bus, such as regulators, they should register >> as early as possible, so the I2C bus master needs to be loaded early. >> Therefore initi

Re: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall

2014-09-22 Thread Max Schwarz
Hi Chris, > > +subsys_initcall(rk3x_i2c_init_driver); > > +module_exit(rk3x_i2c_exit_driver); > > This means that the driver cannot be used as a loadable module any more, > right? > > In that case, you should probably turn the tristate option in Kconfig into a > bool. I'm sorry, I see now that

Re: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall

2014-09-22 Thread Max Schwarz
Hi Chris, Am Montag, 22. September 2014, 15:24:35 schrieb Chris Zhong: > Some device using this bus, such as regulators, they should register > as early as possible, so the I2C bus master needs to be loaded early. > Therefore initialize via subsys_initcall() is better. You could also use probe de

[PATCH] i2c-rk3x: move setup to the earlier subsys initcall

2014-09-22 Thread Chris Zhong
Some device using this bus, such as regulators, they should register as early as possible, so the I2C bus master needs to be loaded early. Therefore initialize via subsys_initcall() is better. Signed-off-by: Chris Zhong --- drivers/i2c/busses/i2c-rk3x.c | 13 - 1 file changed, 12