Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-07-26 Thread Michal Simek
Hi, On 27. 07. 20 8:16, Qiushi Wu wrote: > Hi Michal, > > Thanks for your reply! > I checked the mailing list for the related emails against this API, but > I didn't find any specific timeline they mentioned. > Maybe we can patch this bug to prevent potential issues at this time > point if you ar

Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-07-20 Thread Michal Simek
Hi Qiushi, On 13. 07. 20 21:41, Qiushi Wu wrote: > Hi Michal, > I think multiple previous patches also fixed similar problems, such as > https://patchwork.kernel.org/patch/2404751/ > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2227849.html > https://patchwork.ozlabs.org/project/li

Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-07-13 Thread Michal Simek
Hi Qiushi, On 17. 06. 20 16:30, David Laight wrote: > From: Wolfram Sang >> Sent: 14 June 2020 10:10 >> >> On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000...@umn.edu wrote: >>> From: Qiushi Wu >>> >>> pm_runtime_get_sync() increments the runtime PM usage counter even >>> when it returns an error

RE: [PATCH] i2c: xiic: Fix reference count leaks.

2020-06-17 Thread David Laight
From: Wolfram Sang > Sent: 14 June 2020 10:10 > > On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000...@umn.edu wrote: > > From: Qiushi Wu > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > when it returns an error code. Thus call pm_runtime_put_noidle() > > if pm_runtime

Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-06-14 Thread Wolfram Sang
On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus call pm_runtime_put_noidle() > if pm_runtime_get_sync() fails. Can you point me to a discussion where i

[PATCH] i2c: xiic: Fix reference count leaks.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management") Signed-off-by: Qiushi Wu --- drivers/i2c/busses/i2c-