Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-09 Thread Wolfram Sang
On Mon, Feb 08, 2021 at 12:19:22AM -0600, Samuel Holland wrote: > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > pointers to optional clocks were replaced by NULL to simplify the resume > callback implementation. However, that commit missed that the IS_ERR > check in mv64x

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Samuel Holland
On 2/8/21 7:20 AM, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote: >> On 2/8/21 12:28 AM, Samuel Holland wrote: >>> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error >>> pointers to optional clocks were replaced by NULL to simplify the resum

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 00:31:34 -0600 Samuel Holland wrote: > On 2/8/21 12:28 AM, Samuel Holland wrote: > > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > > pointers to optional clocks were replaced by NULL to simplify the resume > > callback implementation. However, that comm

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Andrew Lunn
On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote: > On 2/8/21 12:28 AM, Samuel Holland wrote: > > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > > pointers to optional clocks were replaced by NULL to simplify the resume > > callback implementation. However, t

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
On 2/8/21 12:28 AM, Samuel Holland wrote: > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > pointers to optional clocks were replaced by NULL to simplify the resume > callback implementation. However, that commit missed that the IS_ERR > check in mv64xxx_of_config should be

[PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error pointers to optional clocks were replaced by NULL to simplify the resume callback implementation. However, that commit missed that the IS_ERR check in mv64xxx_of_config should be replaced with a NULL check. As a result, the chec

[PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-07 Thread Samuel Holland
In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error pointers to optional clocks were replaced by NULL to simplify the resume callback implementation. However, that commit missed that the IS_ERR check in mv64xxx_of_config should be replaced with a NULL check. As a result, the chec