Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-09 Thread Stephen Douthit
> So, I'll wait for his tests and then send it to Linus ASAP. I think it > should be in rc5. I've been able to confirm the regression my patch introduced, and the fix from Pontus. Doing a block read of the SPD EEPROM with my patch everything is shifted by a byte: [root@localhost ~]# i2cdump -y

Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-07 Thread Wolfram Sang
> Thank you! Is it safe to asume it will be backported to 4.4 stable > branch and upwards as the problematic commit did (once in mainline)? Yes, it has a Fixes: and a stable tag. That should do. > > Might have been good to CC the patch author of the problematic commit, > > too. > > Yes, of cour

Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-06 Thread Stephen Douthit
On 10/05/2017 10:13 AM, Pontus Andersson wrote: On Thu, Oct 05, 2017 at 02:41:33PM +0200, Wolfram Sang wrote: On Mon, Oct 02, 2017 at 02:45:19PM +0200, Pontus Andersson wrote: Commit b6c159a9cb69 ("i2c: ismt: Don't duplicate the receive length for block reads") broke I2C block reads. It aimed t

Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-05 Thread Pontus Andersson
On Thu, Oct 05, 2017 at 02:41:33PM +0200, Wolfram Sang wrote: > On Mon, Oct 02, 2017 at 02:45:19PM +0200, Pontus Andersson wrote: > > Commit b6c159a9cb69 ("i2c: ismt: Don't duplicate the receive length for > > block reads") broke I2C block reads. It aimed to fix normal SMBus block > > read, but cha

Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-05 Thread Wolfram Sang
On Mon, Oct 02, 2017 at 02:45:19PM +0200, Pontus Andersson wrote: > Commit b6c159a9cb69 ("i2c: ismt: Don't duplicate the receive length for > block reads") broke I2C block reads. It aimed to fix normal SMBus block > read, but changed the correct behavior of I2C block read in the process. > > Accor

[PATCH] i2c: ismt: Separate I2C block read from SMBus block read

2017-10-02 Thread Pontus Andersson
Commit b6c159a9cb69 ("i2c: ismt: Don't duplicate the receive length for block reads") broke I2C block reads. It aimed to fix normal SMBus block read, but changed the correct behavior of I2C block read in the process. According to Documentation/i2c/smbus-protocol, one vital difference between norma