Re: [PATCH] i2c: designware: Add base addr info

2021-03-29 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v5.12-rc5 next-20210329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH] i2c: designware: Add base addr info

2021-03-27 Thread Andy Shevchenko
On Sat, Mar 27, 2021 at 8:18 PM Daniel Gomez wrote: > On Fri, 26 Mar 2021 at 13:28, Andy Shevchenko > wrote: > > On Fri, Mar 26, 2021 at 11:35:08AM +0100, Daniel Gomez wrote: ... > > It's a good question. On one hand we know that resource_size_t is a simple > > redefinition of phys_addr_t, but

Re: [PATCH] i2c: designware: Add base addr info

2021-03-27 Thread Daniel Gomez
On Fri, 26 Mar 2021 at 13:28, Andy Shevchenko wrote: > > On Fri, Mar 26, 2021 at 11:35:08AM +0100, Daniel Gomez wrote: > > On Thu, 25 Mar 2021 at 16:43, Andy Shevchenko > > wrote: > > > On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote: > > ... > > > > > Add i2c hw base address in the

Re: [PATCH] i2c: designware: Add base addr info

2021-03-26 Thread Andy Shevchenko
On Fri, Mar 26, 2021 at 11:35:08AM +0100, Daniel Gomez wrote: > On Thu, 25 Mar 2021 at 16:43, Andy Shevchenko > wrote: > > On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote: ... > > > Add i2c hw base address in the adapter name and when the device is > > > probed. > > > > Why? > > We

Re: [PATCH] i2c: designware: Add base addr info

2021-03-26 Thread Daniel Gomez
Hi Andy, On Thu, 25 Mar 2021 at 16:43, Andy Shevchenko wrote: > > On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote: > > Add i2c hw base address in the adapter name and when the device is > > probed. > > Why? > We have /proc/iomem for that. The initial reason was because I wasn't aware

Re: [PATCH] i2c: designware: Add base addr info

2021-03-25 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v5.12-rc4 next-20210325] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH] i2c: designware: Add base addr info

2021-03-25 Thread Andy Shevchenko
On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote: > Add i2c hw base address in the adapter name and when the device is > probed. Why? We have /proc/iomem for that. Sorry, I don't see value of this change. Some comments below just to let you know about style:ish issues. ... >

[PATCH] i2c: designware: Add base addr info

2021-03-25 Thread Daniel Gomez
Add i2c hw base address in the adapter name and when the device is probed. Output: root@qt5222:~# dmesg | grep -i syno [0.347045] i2c_designware AMDI0010:00: Synopsys DesignWare I2C adapter at 0xfedc4000 [0.348843] i2c_designware AMDI0010:01: Synopsys DesignWare I2C adapter at 0xfedc5000 r