Re: [PATCH] hyper-v: Check for ring buffer in hv_get_bytes_to_read/write

2019-03-13 Thread Mohammed Gamal
ha Levin ; Dexuan Cui > > ; Stephen Hemminger ; > > Long Li ; KY Srinivasan ; > Haiyang > > Zhang ; vkuznets ; > linux- > > ker...@vger.kernel.org > > Subject: Re: [PATCH] hyper-v: Check for ring buffer in > > hv_get_bytes_to_read/write > > > >

RE: [PATCH] hyper-v: Check for ring buffer in hv_get_bytes_to_read/write

2019-03-07 Thread Michael Kelley
From: Mohammed Gamal Sent: Thursday, March 7, 2019 10:32 AM > > > > Could you elaborate on the code paths where > > hv_get_bytes_to_read/write() could be called when the ring buffer > > isn't yet allocated?  My sense is that Kim Brown's patch will address > > all of the code paths that involved s

Re: [PATCH] hyper-v: Check for ring buffer in hv_get_bytes_to_read/write

2019-03-07 Thread Mohammed Gamal
On Thu, 2019-03-07 at 17:33 +, Michael Kelley wrote: > From: Mohammed Gamal Sent: Thursday, March 7, > 2019 8:36 AM > > > > This patch adds a check for the presence of the ring buffer in > > hv_get_bytes_to_read/write() to avoid possible NULL pointer > > dereferences. > > If the ring buffer i

RE: [PATCH] hyper-v: Check for ring buffer in hv_get_bytes_to_read/write

2019-03-07 Thread Michael Kelley
From: Mohammed Gamal Sent: Thursday, March 7, 2019 8:36 AM > > This patch adds a check for the presence of the ring buffer in > hv_get_bytes_to_read/write() to avoid possible NULL pointer dereferences. > If the ring buffer is not yet allocated, return 0 bytes to be read/written. > > The root cau

[PATCH] hyper-v: Check for ring buffer in hv_get_bytes_to_read/write

2019-03-07 Thread Mohammed Gamal
This patch adds a check for the presence of the ring buffer in hv_get_bytes_to_read/write() to avoid possible NULL pointer dereferences. If the ring buffer is not yet allocated, return 0 bytes to be read/written. The root cause is that code that accesses the ring buffer including hv_get_bytes_to_r