Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-11 Thread Darrick J. Wong
On Thu, Aug 30, 2007 at 11:57:43AM +0200, Jean Delvare wrote: > OK, that's a bit different then, but I'm still not sure that there is > much value in exporting these values in sysfs, in particular if there > is no way to reset them. It turns out there _is_ a way to reset them; the next iteration o

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-06 Thread Henrique de Moraes Holschuh
On Thu, 06 Sep 2007, Jean Delvare wrote: > On Mon, 3 Sep 2007 20:22:25 -0300, Henrique de Moraes Holschuh wrote: > > On Mon, 03 Sep 2007, Jean Delvare wrote: > > > I see that the power supply class units are 10^-6 A and 10^-6 W, so if > > > we are supposed to be compatible, I guess we'll have to us

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-06 Thread Jean Delvare
On Mon, 3 Sep 2007 20:22:25 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 03 Sep 2007, Jean Delvare wrote: > > I see that the power supply class units are 10^-6 A and 10^-6 W, so if > > we are supposed to be compatible, I guess we'll have to use this too. > > There was a good reason for that

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-03 Thread Henrique de Moraes Holschuh
On Mon, 03 Sep 2007, Jean Delvare wrote: > On Sun, 2 Sep 2007 23:02:01 -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 02 Sep 2007, Jean Delvare wrote: > > > I guess power[1-*]_average would be OK? > > > > AFAIK, yes. It is probably not 100% in sync with the power supply class, > > though.

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-03 Thread Jean Delvare
On Sun, 2 Sep 2007 23:02:01 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 02 Sep 2007, Jean Delvare wrote: > > I guess power[1-*]_average would be OK? > > AFAIK, yes. It is probably not 100% in sync with the power supply class, > though. Is the power supply class creating sysfs files? I se

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-02 Thread Henrique de Moraes Holschuh
On Sun, 02 Sep 2007, Jean Delvare wrote: > On Sat, 1 Sep 2007 16:44:17 -0300, Henrique de Moraes Holschuh wrote: > > On Sat, 01 Sep 2007, Shem Multinymous wrote: > > > > Should we add power?_10sec_avg_input? IIRC thinkpads export that, > > > > too. > > > > I'd say it is enough to know it is an ave

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-02 Thread Jean Delvare
On Sat, 1 Sep 2007 16:44:17 -0300, Henrique de Moraes Holschuh wrote: > On Sat, 01 Sep 2007, Shem Multinymous wrote: > > > Should we add power?_10sec_avg_input? IIRC thinkpads export that, > > > too. > > I'd say it is enough to know it is an average, you don't need to specify HOW > it is averaged.

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-01 Thread Henrique de Moraes Holschuh
On Sat, 01 Sep 2007, Shem Multinymous wrote: > > Should we add power?_10sec_avg_input? IIRC thinkpads export that, > > too. I'd say it is enough to know it is an average, you don't need to specify HOW it is averaged. But there is a real need to export both instantaneous and averaged values in pow

Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-01 Thread Shem Multinymous
On 9/1/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > diff --git a/Documentation/hwmon/sysfs-interface > > b/Documentation/hwmon/sysfs-interface > > index b3a9e1b..da546ce 100644 > > --- a/Documentation/hwmon/sysfs-interface > > +++ b/Documentation/hwmon/sysfs-interface > > @@ -304,6 +304,21 @@ c

Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-01 Thread Pavel Machek
Hi! > diff --git a/Documentation/hwmon/sysfs-interface > b/Documentation/hwmon/sysfs-interface > index b3a9e1b..da546ce 100644 > --- a/Documentation/hwmon/sysfs-interface > +++ b/Documentation/hwmon/sysfs-interface > @@ -304,6 +304,21 @@ curr[1-*]_input Current input value > Unit:

Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-08-30 Thread Jean Delvare
Hi Darrick, On Wed, 29 Aug 2007 07:50:03 -0700, Darrick J. Wong wrote: > On Wed, Aug 29, 2007 at 11:10:52AM +0200, Jean Delvare wrote: > > > I'm not sure if we want these "historical" files. We don't have them for > > the other input types, and I believe that it's not the driver's job to > > comp

Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-08-29 Thread Darrick J. Wong
On Wed, Aug 29, 2007 at 11:10:52AM +0200, Jean Delvare wrote: > I'm not sure if we want these "historical" files. We don't have them for > the other input types, and I believe that it's not the driver's job to > compute and export these values. If anyone cares about the history of In the case of

Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-08-29 Thread Jean Delvare
Hi Darrick, On Tue, 28 Aug 2007 09:44:40 -0700, Darrick J. Wong wrote: > Update the hwmon sysfs interface documentation to include a specification > for power meters. > > Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> > --- > > Documentation/hwmon/sysfs-interface | 15 +++ > 1

[PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-08-28 Thread Darrick J. Wong
Update the hwmon sysfs interface documentation to include a specification for power meters. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- Documentation/hwmon/sysfs-interface | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/Documentation/hwmon/sysfs