Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Guenter Roeck
On 8/6/20 11:23 PM, Stephen Kitt wrote: > On Thu, 6 Aug 2020 14:48:58 -0700, Guenter Roeck wrote: >> On 8/6/20 1:12 PM, Stephen Kitt wrote: >>> On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck >>> wrote: On 8/6/20 9:16 AM, Stephen Kitt wrote: > [...] Also, I am not convinced that re

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Stephen Kitt
On Thu, 6 Aug 2020 14:48:58 -0700, Guenter Roeck wrote: > On 8/6/20 1:12 PM, Stephen Kitt wrote: > > On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck > > wrote: > >> On 8/6/20 9:16 AM, Stephen Kitt wrote: [...] > >> Also, I am not convinced that replacements such as > >> > >> - { "ipsps1", 0

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread kernel test robot
Hi Stephen, Thank you for the patch! Yet something to improve: [auto build test ERROR on bcf876870b95592b52519ed4aafcf9d95999bc9c] url: https://github.com/0day-ci/linux/commits/Stephen-Kitt/hwmon-pmbus-use-simple-i2c-probe-function/20200807-024648 base:bcf876870b95592b52519ed4aafcf9d9599

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread kernel test robot
Hi Stephen, Thank you for the patch! Yet something to improve: [auto build test ERROR on bcf876870b95592b52519ed4aafcf9d95999bc9c] url: https://github.com/0day-ci/linux/commits/Stephen-Kitt/hwmon-pmbus-use-simple-i2c-probe-function/20200807-024648 base:bcf876870b95592b52519ed4aafcf9d9599

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Guenter Roeck
On 8/6/20 1:12 PM, Stephen Kitt wrote: > On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck wrote: >> On 8/6/20 9:16 AM, Stephen Kitt wrote: >>> pmbus_do_probe doesn't use the id information provided in its second >>> argument, so this can be removed, which then allows using the >>> single-parameter

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Stephen Kitt
On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck wrote: > On 8/6/20 9:16 AM, Stephen Kitt wrote: > > pmbus_do_probe doesn't use the id information provided in its second > > argument, so this can be removed, which then allows using the > > single-parameter i2c probe function ("probe_new") for prob

[PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Stephen Kitt
pmbus_do_probe doesn't use the id information provided in its second argument, so this can be removed, which then allows using the single-parameter i2c probe function ("probe_new") for probes which don't use the id information either. This avoids scanning the identifier tables during probes. Addi

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Guenter Roeck
On 8/6/20 9:16 AM, Stephen Kitt wrote: > pmbus_do_probe doesn't use the id information provided in its second > argument, so this can be removed, which then allows using the > single-parameter i2c probe function ("probe_new") for probes which > don't use the id information either. > > This avoids