Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix

2007-06-25 Thread Soeren Sonnenburg
On Mon, 2007-06-25 at 20:20 +0200, Rudolf Marek wrote: > > Hi Rudolf, > > > > just one more update: > > > > When I put my machine into s2ram and make it resume, one of the coretemp > > sensors gets lost. Ahh and I am already rmmod coretemp / loading > > microcode after resume / insmod coretemp...

Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix

2007-06-25 Thread Rudolf Marek
Hi Rudolf, just one more update: When I put my machine into s2ram and make it resume, one of the coretemp sensors gets lost. Ahh and I am already rmmod coretemp / loading microcode after resume / insmod coretemp... Hello, If I understand correctly you unload the driver before suspend. Resume,

Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix

2007-06-25 Thread Soeren Sonnenburg
On Thu, 2007-06-21 at 22:57 +0200, Rudolf Marek wrote: > Hello Soeren, [...] > Soeren pointed at some T60, T60p BIOS update and luckily, there is a > easy way > how to extract the microcode update and even convert it into the .txt > format as > microcode update utility (http://www.urbanmyth.org/m

Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix

2007-06-21 Thread Soeren Sonnenburg
On Thu, 2007-06-21 at 22:57 +0200, Rudolf Marek wrote: > Hello Soeren, > > Sorry for the delay. > > I'm ccing all lists maybe some other people are interested. There is known > errata AE18 which prevents coretemp from working correctly on some mobile > Core > processors (family 6 model e). My

Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix

2007-06-21 Thread Rudolf Marek
Hello Soeren, Sorry for the delay. I'm ccing all lists maybe some other people are interested. There is known errata AE18 which prevents coretemp from working correctly on some mobile Core processors (family 6 model e). My driver refuses to load and now thanks to soeren will not crash ;) Howe

Re: [PATCH] hwmon/coretemp: Fix a broken error path

2007-06-18 Thread Jean Delvare
Hi Soeren, On Sun, 17 Jun 2007 11:16:43 +0200, Soeren Sonnenburg wrote: > On Sat, 2007-06-16 at 23:17 +0200, Jean Delvare wrote: > > Thanks for reporting. Indeed this patch is broken, sorry for > > overlooking it. I tested it but my hardware is such that the faulty > > error path was never taken.

Re: [PATCH] hwmon/coretemp: Fix a broken error path

2007-06-17 Thread Rudolf Marek
Hello all, Sorry for the delay, I was hiking in the mountains. this patch indeed fixes the problem. Thanks! Jean, thanks for the quick fix! Well obviously my fault :/ Sorry. Unfortunately the coretemp sensors are simply never there when that patch is applied... which I guess was the intenti

Re: [PATCH] hwmon/coretemp: Fix a broken error path

2007-06-17 Thread Soeren Sonnenburg
On Sat, 2007-06-16 at 23:17 +0200, Jean Delvare wrote: > Hi Soeren, Hi Jean, [...] > Thanks for reporting. Indeed this patch is broken, sorry for > overlooking it. I tested it but my hardware is such that the faulty > error path was never taken. Please test the following patch (on top of > git-c

[PATCH] hwmon/coretemp: Fix a broken error path

2007-06-16 Thread Jean Delvare
Hi Soeren, On Sat, 16 Jun 2007 22:43:05 +0200, Soeren Sonnenburg wrote: > this commit makes coretemp fail on my macbook pro. > > 1) rmmod oopses (see below) > 2) it breaks s2ram > > Soeren > > commit 67f363b1f6a31cf5027a97372f64bcced4f05ba6 > Author: Rudolf Marek <[EMAIL PROTECTED]> > Date: S