Re: [PATCH] hung_task: change sysctl_hung_task_check_count to int

2013-09-13 Thread Li Zefan
>> On 2013/9/14 10:47, Li Zefan wrote: >>> As sysctl_hung_task_check_count is unsigned long, when this value is >>> assigned to max_count in check_hung_uninterruptible_tasks(), it's >>> truncated to int type. >>> >>> Therefore if we write 2^32 to sysctl.hung_task_check_count, hung task >>> detectio

Re: [PATCH] hung_task: change sysctl_hung_task_check_count to int

2013-09-13 Thread Ingo Molnar
* Li Zefan wrote: > Cc: Ingo, as this touched include/linux/sched/. > > On 2013/9/14 10:47, Li Zefan wrote: > > As sysctl_hung_task_check_count is unsigned long, when this value is > > assigned to max_count in check_hung_uninterruptible_tasks(), it's > > truncated to int type. > > > > Therefor

Re: [PATCH] hung_task: change sysctl_hung_task_check_count to int

2013-09-13 Thread Li Zefan
Cc: Ingo, as this touched include/linux/sched/. On 2013/9/14 10:47, Li Zefan wrote: > As sysctl_hung_task_check_count is unsigned long, when this value is > assigned to max_count in check_hung_uninterruptible_tasks(), it's > truncated to int type. > > Therefore if we write 2^32 to sysctl.hung_tas

[PATCH] hung_task: change sysctl_hung_task_check_count to int

2013-09-13 Thread Li Zefan
As sysctl_hung_task_check_count is unsigned long, when this value is assigned to max_count in check_hung_uninterruptible_tasks(), it's truncated to int type. Therefore if we write 2^32 to sysctl.hung_task_check_count, hung task detection will be effectively disabled. Not a big deal, but still it'