Re: [PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread Akinobu Mita
On Sat, Apr 28, 2007 at 07:50:39AM -0700, William Lee Irwin III wrote: > On Sat, Apr 28, 2007 at 04:19:23PM +0900, Akinobu Mita wrote: > > init_hugetlbfs_fs() needs to unregister hugetlbfs > > when kern_mount() returns error. > > Cc: William Irwin <[EMAIL PROTECTED]> > > Signed-off-by: Akinobu Mita

Re: [PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread William Lee Irwin III
On Sat, Apr 28, 2007 at 04:19:23PM +0900, Akinobu Mita wrote: > init_hugetlbfs_fs() needs to unregister hugetlbfs > when kern_mount() returns error. > Cc: William Irwin <[EMAIL PROTECTED]> > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> This patch resolves a clear failure to error check. Acked-

Re: [PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread William Lee Irwin III
On Sat, Apr 28, 2007 at 11:44:43AM +0400, Alexey Dobriyan wrote: > On 4/28/07, Akinobu Mita <[EMAIL PROTECTED]> wrote: > >init_hugetlbfs_fs() needs to unregister hugetlbfs > >when kern_mount() returns error. > HUGETLBFS is bool, so __init function should panic more and > __exit function should be r

Re: [PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread Akinobu Mita
On Sat, Apr 28, 2007 at 11:44:43AM +0400, Alexey Dobriyan wrote: > On 4/28/07, Akinobu Mita <[EMAIL PROTECTED]> wrote: > >init_hugetlbfs_fs() needs to unregister hugetlbfs > >when kern_mount() returns error. > > HUGETLBFS is bool, so __init function should panic more and > __exit function should b

Re: [PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread Alexey Dobriyan
On 4/28/07, Akinobu Mita <[EMAIL PROTECTED]> wrote: init_hugetlbfs_fs() needs to unregister hugetlbfs when kern_mount() returns error. HUGETLBFS is bool, so __init function should panic more and __exit function should be removed. Or someone is planning making it tristate? - To unsubscribe from

[PATCH] hugetlbfs: fix error path in module_init

2007-04-28 Thread Akinobu Mita
init_hugetlbfs_fs() needs to unregister hugetlbfs when kern_mount() returns error. Cc: William Irwin <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- fs/hugetlbfs/inode.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) Index: 2.6-mm/fs/huge