Re: [PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-23 Thread Joe Perches
On Sun, 2020-08-23 at 16:21 +0100, Matthew Wilcox wrote: > On Wed, Aug 19, 2020 at 10:14:11AM +0200, Giuseppe Scrivano wrote: > > > > - cft->file_offset = offsetof(struct hugetlb_cgroup, > > > > events_file[idx]), > > > > + cft->file_offset = offsetof(struct hugetlb_cgroup, > > > > ev

Re: [PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-23 Thread Matthew Wilcox
On Sun, Aug 23, 2020 at 04:21:30PM +0100, Matthew Wilcox wrote: > On Wed, Aug 19, 2020 at 10:14:11AM +0200, Giuseppe Scrivano wrote: > > >> -cft->file_offset = offsetof(struct hugetlb_cgroup, > > >> events_file[idx]), > > >> +cft->file_offset = offsetof(struct hugetlb_cgroup, > >

Re: [PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-23 Thread Matthew Wilcox
On Wed, Aug 19, 2020 at 10:14:11AM +0200, Giuseppe Scrivano wrote: > >> - cft->file_offset = offsetof(struct hugetlb_cgroup, events_file[idx]), > >> + cft->file_offset = offsetof(struct hugetlb_cgroup, events_file[idx]); > >>cft->flags = CFTYPE_NOT_ON_ROOT; > > I think in this case having tw

Re: [PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-19 Thread Giuseppe Scrivano
Andrew Morton writes: > On Tue, 18 Aug 2020 06:43:33 + Xu Wang wrote: > >> Replace a comma between expression statements by a semicolon. >> >> ... >> >> --- a/mm/hugetlb_cgroup.c >> +++ b/mm/hugetlb_cgroup.c >> @@ -655,7 +655,7 @@ static void __init __hugetlb_cgroup_file_dfl_init(int >> id

Re: [PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-18 Thread Andrew Morton
On Tue, 18 Aug 2020 06:43:33 + Xu Wang wrote: > Replace a comma between expression statements by a semicolon. > > ... > > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -655,7 +655,7 @@ static void __init __hugetlb_cgroup_file_dfl_init(int idx) > snprintf(cft->name, MAX_CFT

[PATCH] hugetlb_cgroup: convert comma to semicolon

2020-08-17 Thread Xu Wang
Replace a comma between expression statements by a semicolon. Signed-off-by: Xu Wang --- mm/hugetlb_cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index aabf65d4d91b..1f87aec9ab5c 100644 --- a/mm/hugetlb_cgroup.c +++ b/m