Re: [PATCH] hid_sensor_magn_3d: Fix scale for rotation from north channels

2015-07-20 Thread Srinivas Pandruvada
Hi Reyad, On Wed, 2015-07-15 at 02:43 -0500, Reyad Attiyat wrote: > Some devices on a hid sensor hub will not report a measurement unit. This > causes the rotation from north channels to have an incorrect scale value. > This patch will set the unit to degrees if the maximum value is 360 when > the

Re: [PATCH] hid_sensor_magn_3d: Fix scale for rotation from north channels

2015-07-19 Thread Reyad Attiyat
Thanks for the review. I don't believe many devices have this problem no need to rush it. On Sun, Jul 19, 2015 at 7:57 AM, Jonathan Cameron wrote: > On 15/07/15 08:43, Reyad Attiyat wrote: >> Some devices on a hid sensor hub will not report a measurement unit. This >> causes the rotation from nor

Re: [PATCH] hid_sensor_magn_3d: Fix scale for rotation from north channels

2015-07-19 Thread Jonathan Cameron
On 15/07/15 08:43, Reyad Attiyat wrote: > Some devices on a hid sensor hub will not report a measurement unit. This > causes the rotation from north channels to have an incorrect scale value. > This patch will set the unit to degrees if the maximum value is 360 when > the unit exponent value is acc

[PATCH] hid_sensor_magn_3d: Fix scale for rotation from north channels

2015-07-15 Thread Reyad Attiyat
Some devices on a hid sensor hub will not report a measurement unit. This causes the rotation from north channels to have an incorrect scale value. This patch will set the unit to degrees if the maximum value is 360 when the unit exponent value is accounted for. Signed-off-by: Reyad Attiyat ---