Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-08 Thread Vojtech Pavlik
On Tue, Feb 08, 2005 at 04:15:53PM +0100, zyphr wrote: > Something looks odd. > I've tested this with 2.6.11-rc3-bk5 + your lasted patch > > cat /sys/module/usbhid/parameters/mousepoll says it's at 2ms > but if I check /proc/bus/usb/devices it's reading 10ms > > I've used parameter under /etc/mod

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-08 Thread Oliver Neukum
Am Dienstag, 8. Februar 2005 16:15 schrieb zyphr: > Something looks odd. > I've tested this with 2.6.11-rc3-bk5 + your lasted patch > > cat /sys/module/usbhid/parameters/mousepoll says it's at 2ms > but if I check /proc/bus/usb/devices it's reading 10ms You're reading the device descriptor. It is

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-08 Thread zyphr
Something looks odd. I've tested this with 2.6.11-rc3-bk5 + your lasted patch cat /sys/module/usbhid/parameters/mousepoll says it's at 2ms but if I check /proc/bus/usb/devices it's reading 10ms I've used parameter under /etc/modules (debian sarge) in there I have added: usbhid mousepoll=2 this u

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
This includes the kernel-parameters.txt-patch, and the hid-core.c-patch, without the extra else-statement. Thanks, Mikkel Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> --- --- clean/Documentation/kernel-parameters.txt +++ dirty/Documentation/kernel-parameters.txt @@ -73,6 +73,7 @@ SWS

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
Alright, I'll send it in a bit! Thanks, Mikkel On Mon, 7 Feb 2005 19:38:18 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Mon, Feb 07, 2005 at 06:56:50PM +0100, Mikkel Krautz wrote: > > Sorry, I now realise that my way of doing this only sets > > hid_mousepoll_interval to the latest-plugg

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
Sorry, I now realise that my way of doing this only sets hid_mousepoll_interval to the latest-plugged-in mouse's polling interval. How should I handle this? Just remove the line, and keep the "0 feature"? Thanks, Mikkel On Mon, 7 Feb 2005 18:51:46 +0100, Mikkel Krautz <[EMAIL PROTECTED]> wrote:

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
Are you talking about the following line? + else + hid_mousepoll_interval = interval; If so, I put it there, to fill a tiny gap, i felt was missing. If no parameter is passed, hid_mousepoll_interval is obviously 0. If a user, who doesn't pass the parameter to

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Randy.Dunlap
Domen Puncer wrote: On 07/02/05 07:59 -0800, Randy.Dunlap wrote: +static unsigned int hid_mousepoll_interval; +module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644); Why is it writable by root? IOW, will writing a new value to it change the operational value dynamically? Also, from the

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Domen Puncer
On 07/02/05 07:59 -0800, Randy.Dunlap wrote: > Mikkel Krautz wrote: > >And, here's an updated version of hid-core.c: > > > >Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> > >--- > >--- clean/drivers/usb/input/hid-core.c > >+++ dirty/drivers/usb/input/hid-core.c ... > >+ > >+static unsigned int hi

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
Randy.Dunlap wrote: > Why is it writable by root? IOW, will writing a new value to it > change the operational value dynamically? Yes, sort of. It requires a re-plug of the mouse, though. :) > Also, from the kernel-parameters.txt patch: > (a) "which" > (b) drop one of the "at"s... either one. O

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Randy.Dunlap
Mikkel Krautz wrote: And, here's an updated version of hid-core.c: Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> --- --- clean/drivers/usb/input/hid-core.c +++ dirty/drivers/usb/input/hid-core.c @@ -37,13 +37,20 @@ * Version Information */ -#define DRIVER_VERSION "v2.0" +#define DRIVER_VER

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
And, here's an updated version of hid-core.c: Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> --- --- clean/drivers/usb/input/hid-core.c +++ dirty/drivers/usb/input/hid-core.c @@ -37,13 +37,20 @@ * Version Information */ -#define DRIVER_VERSION "v2.0" +#define DRIVER_VERSION "v2.01" #defin

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Mikkel Krautz
Here's an updated version of kernel-parameters.txt: Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> --- --- clean/Documentation/kernel-parameters.txt +++ dirty/Documentation/kernel-parameters.txt @@ -73,6 +73,7 @@ SWSUSP Software suspension is enabled. TS Appropriate touchsc

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-06 Thread Mikkel Krautz
Thanks for the suggestions. :) I'm wondering if there perhaps is a more clean way to do this? Perhaps something that would give the user the possibility to change the polling interface per device, or something like that, perhaps exported to sysfs? Though, since you mentioned that the endpoint desc

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-06 Thread Vojtech Pavlik
On Sun, Dec 19, 2004 at 01:52:06AM +, Mikkel Krautz wrote: > On Sat, 18 Dec 2004 08:53:31 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > On Sat, Dec 18, 2004 at 05:39:25PM +, Mikkel Krautz wrote: > > > On Fri, 17 Dec 2004 18:59:48 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > > > What about