Re: [PATCH] hfs: add error checking for hfs_find_init()

2013-04-07 Thread Vyacheslav Dubeyko
Hi Alexey, On Apr 7, 2013, at 1:13 AM, Alexey Khoroshilov wrote: > Hi Vyacheslav, > > On 03/30/2013 03:35 PM, Vyacheslav Dubeyko wrote: >>> Found by Linux Driver Verification project (linuxtesting.org). >>> >>> Signed-off-by: Alexey Khoroshilov >>> --- >>> fs/hfs/catalog.c | 12 +---

Re: [PATCH] hfs: add error checking for hfs_find_init()

2013-04-06 Thread Alexey Khoroshilov
Hi Vyacheslav, On 03/30/2013 03:35 PM, Vyacheslav Dubeyko wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- fs/hfs/catalog.c | 12 +--- fs/hfs/dir.c |8 ++-- fs/hfs/extent.c | 48 +-

Re: [PATCH] hfs: add error checking for hfs_find_init()

2013-03-30 Thread Hin-Tak Leung
--- On Sat, 30/3/13, Vyacheslav Dubeyko wrote: > From: Vyacheslav Dubeyko > Subject: Re: [PATCH] hfs: add error checking for hfs_find_init() > To: "Alexey Khoroshilov" > Cc: "Al Viro" , "Artem Bityutskiy" > , "Christoph Hellwig" , > l

Re: [PATCH] hfs: add error checking for hfs_find_init()

2013-03-30 Thread Vyacheslav Dubeyko
Hi Alexey, On Mar 30, 2013, at 12:44 AM, Alexey Khoroshilov wrote: > hfs_find_init() may fail with ENOMEM, but there are places, > where the returned value is not checked. The consequences can be > very unpleasant, e.g. kfree uninitialized pointer and > inappropriate mutex unlocking. > > The pat

[PATCH] hfs: add error checking for hfs_find_init()

2013-03-29 Thread Alexey Khoroshilov
hfs_find_init() may fail with ENOMEM, but there are places, where the returned value is not checked. The consequences can be very unpleasant, e.g. kfree uninitialized pointer and inappropriate mutex unlocking. The patch adds checks for errors in hfs_find_init(). Found by Linux Driver Verification