答复: [PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel

2018-12-27 Thread Qu, Jim
...@lists.freedesktop.org; Daniel Vetter; pakki...@umn.edu; Deucher, Alexander; Gao, Likun; Zhu, Rex; Koenig, Christian; Zhang, Hawking 主题: [PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel adev->firmware.fw_buf being not NULL may not indicate kernel buffer is created successful

RE: [PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel

2018-12-26 Thread Huang, Ray
Rex ; Huang, Ray > ; Zhang, Hawking ; Xu, > Feifei ; Gao, Likun ; Francis, > David ; amd-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; linux-kernel@vger.kernel.org > Subject: [PATCH] gpu: drm: fix an improper check of > amdgpu_bo_create_kernel > > adev->

[PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel

2018-12-25 Thread Kangjie Lu
adev->firmware.fw_buf being not NULL may not indicate kernel buffer is created successful. A better way is to check the status (return value) of it. The fix does so. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 18 -- 1 file changed, 12 insertions(+),