Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > > > the variable sender is dereferenced in line 190, so it is no reason to > > > check > > > null again in line 198. > > > > Did you mean "The variable 'chan'"? > sorry, my fault. so should I send a new version to correct the typo? Yep. David -- To unsubscribe from this lis

Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread Cong Ding
On Tue, Jan 15, 2013 at 10:39:23AM +, David Howells wrote: > Cong Ding wrote: > > > the variable sender is dereferenced in line 190, so it is no reason to check > > null again in line 198. > > Did you mean "The variable 'chan'"? sorry, my fault. so should I send a new version to correct the

Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-15 Thread David Howells
Cong Ding wrote: > the variable sender is dereferenced in line 190, so it is no reason to check > null again in line 198. Did you mean "The variable 'chan'"? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

[PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

2013-01-14 Thread Cong Ding
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198. Signed-off-by: Cong Ding --- drivers/gpu/drm/nouveau/nouveau_fence.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/driv