Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()

2020-11-30 Thread Andy Shevchenko
On Mon, Nov 30, 2020 at 6:37 PM Bartosz Golaszewski wrote: > > On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko > wrote: > > > > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean > > wrote: > > > > > > There is no matching spi_get_drvdata() call in the driver, so there is no > > > need to do spi

Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()

2020-11-30 Thread Bartosz Golaszewski
On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko wrote: > > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean > wrote: > > > > There is no matching spi_get_drvdata() call in the driver, so there is no > > need to do spi_set_drvdata(). This looks like it probably was copied from a > > driver that

Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()

2020-11-19 Thread Andy Shevchenko
On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean wrote: > > There is no matching spi_get_drvdata() call in the driver, so there is no > need to do spi_set_drvdata(). This looks like it probably was copied from a > driver that used both spi_set_drvdata() & spi_get_drvdata(). While above luckily

[PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()

2020-11-19 Thread Alexandru Ardelean
There is no matching spi_get_drvdata() call in the driver, so there is no need to do spi_set_drvdata(). This looks like it probably was copied from a driver that used both spi_set_drvdata() & spi_get_drvdata(). Signed-off-by: Alexandru Ardelean --- drivers/gpio/gpio-xra1403.c | 10 +- 1