Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-03 Thread Álvaro Fernández Rojas
Hi Linus, > El 2 mar 2021, a las 23:39, Linus Walleij escribió: > > On Tue, Mar 2, 2021 at 7:14 PM Álvaro Fernández Rojas > wrote: > >> I'm trying to add support for bcm63xx pin controllers, and Linus >> suggested that I could use gpio regmap instead of adding duplicated code. >> However, I n

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Linus Walleij
On Tue, Mar 2, 2021 at 7:14 PM Álvaro Fernández Rojas wrote: > I'm trying to add support for bcm63xx pin controllers, and Linus > suggested that I could use gpio regmap instead of adding duplicated code. > However, I need to access gpio_chip inside gpio_regmap to call > pinctrl_add_gpio_range() w

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Álvaro Fernández Rojas
Hi Michael, El 02/03/2021 a las 20:24, Michael Walle escribió: Hi, Am 2021-03-02 19:14, schrieb Álvaro Fernández Rojas: El 02/03/2021 a las 19:10, Michael Walle escribió: Am 2021-03-02 19:06, schrieb Álvaro Fernández Rojas: struct gpio_regmap should be declared in gpio/regmap.h. This way oth

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Michael Walle
Hi, Am 2021-03-02 19:14, schrieb Álvaro Fernández Rojas: El 02/03/2021 a las 19:10, Michael Walle escribió: Am 2021-03-02 19:06, schrieb Álvaro Fernández Rojas: struct gpio_regmap should be declared in gpio/regmap.h. This way other drivers can access the structure data when registering a gpio

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Álvaro Fernández Rojas
Hi Michael, El 02/03/2021 a las 19:10, Michael Walle escribió: Hi, Am 2021-03-02 19:06, schrieb Álvaro Fernández Rojas: struct gpio_regmap should be declared in gpio/regmap.h. This way other drivers can access the structure data when registering a gpio regmap controller. The intention was

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Michael Walle
Hi, Am 2021-03-02 19:06, schrieb Álvaro Fernández Rojas: struct gpio_regmap should be declared in gpio/regmap.h. This way other drivers can access the structure data when registering a gpio regmap controller. The intention was really to keep this private to the gpio-regmap driver. Why do you

[PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Álvaro Fernández Rojas
struct gpio_regmap should be declared in gpio/regmap.h. This way other drivers can access the structure data when registering a gpio regmap controller. Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap") Signed-off-by: Álvaro Fernández Rojas --- drivers/gpio/gpio-regmap.c