Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-16 Thread Linus Walleij
On Fri, May 16, 2014 at 5:29 PM, Alexandre Courbot wrote: > On 05/17/2014 12:25 AM, Linus Walleij wrote: >> I got a horde of mails from Fengguang's autobuilder, I think you got >> them as well ... else tell me and I'll dig them up. > > Mmm, it seems like I didn't get any mail. Could you follow ot

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-16 Thread Alexandre Courbot
On 05/17/2014 12:25 AM, Linus Walleij wrote: On Tue, May 13, 2014 at 3:23 PM, Alexandre Courbot wrote: On Tue, May 13, 2014 at 10:17 PM, Linus Walleij wrote: This results in all references to gpiod_* functions in of_gpio.h being gone, which is the way it should be since this file is part of

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-16 Thread Linus Walleij
On Tue, May 13, 2014 at 3:23 PM, Alexandre Courbot wrote: > On Tue, May 13, 2014 at 10:17 PM, Linus Walleij > wrote: >>> This results in all references to gpiod_* functions in of_gpio.h being >>> gone, which is the way it should be since this file is part of the old >>> integer GPIO interface. >

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-13 Thread Alexandre Courbot
On Tue, May 13, 2014 at 10:23 PM, Alexandre Courbot wrote: > On Tue, May 13, 2014 at 10:17 PM, Linus Walleij > wrote: >> On Sun, May 4, 2014 at 5:45 AM, Alexandre Courbot >> wrote: >> >>> of_get_named_gpiod_flags() is visible and directly usable by GPIO >>> consumers, but it really should not a

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-13 Thread Alexandre Courbot
On Tue, May 13, 2014 at 10:17 PM, Linus Walleij wrote: > On Sun, May 4, 2014 at 5:45 AM, Alexandre Courbot wrote: > >> of_get_named_gpiod_flags() is visible and directly usable by GPIO >> consumers, but it really should not as the gpiod interface relies >> on the simpler gpiod_get() to provide pr

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-13 Thread Linus Walleij
On Sun, May 4, 2014 at 5:45 AM, Alexandre Courbot wrote: > of_get_named_gpiod_flags() is visible and directly usable by GPIO > consumers, but it really should not as the gpiod interface relies > on the simpler gpiod_get() to provide properly-configured GPIOs. > > of_get_named_gpiod_flags() is jus

Re: [PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-13 Thread Linus Walleij
On Sun, May 4, 2014 at 5:45 AM, Alexandre Courbot wrote: > of_get_named_gpiod_flags() is visible and directly usable by GPIO > consumers, but it really should not as the gpiod interface relies > on the simpler gpiod_get() to provide properly-configured GPIOs. > > of_get_named_gpiod_flags() is jus

[PATCH] gpio: make of_get_named_gpiod_flags() private

2014-05-03 Thread Alexandre Courbot
of_get_named_gpiod_flags() is visible and directly usable by GPIO consumers, but it really should not as the gpiod interface relies on the simpler gpiod_get() to provide properly-configured GPIOs. of_get_named_gpiod_flags() is just used internally by gpiolib to implement gpiod_get(), and by the ol