Hi abdoulaye,
On Fri, 30 May 2014 00:32:02 +0200 abdoulaye berthe wrote:
>
> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> + panic("gpio: removing gpiochip with gpios still
> requested\n");
Someone else already commented that panic is probably overkill
This avoids handling gpiochip remove error in device
remove handler.
Signed-off-by: abdoulaye berthe
---
drivers/gpio/gpiolib.c | 24 +++-
include/linux/gpio/driver.h | 2 +-
2 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/driver
On Fri, May 23, 2014 at 7:03 PM, abdoulaye berthe wrote:
> This avoids handling gpiochip remove error in device
> remove handler.
>
> Signed-off-by: abdoulaye berthe
In general this is the right thing to do.
> for (id = 0; id < chip->ngpio; id++) {
> - if (test_bit(FLAG_R
On Mon, May 26, 2014 at 1:40 AM, abdoulaye berthe wrote:
> Well, ignoring the return value as it is done in gpio-bt8xx makes the
> compiler complain and display a warning message. The problem with
> false warning is that it might distract you.
Isn't the warning due to the __must_check in the func
Well, ignoring the return value as it is done in gpio-bt8xx makes the
compiler complain and display a warning message. The problem with
false warning is that it might distract you. I think that the patch
will makes things consistent once completed
Thanks a lot for the review.
On Sun, May 25, 2014
On Sat, May 24, 2014 at 2:12 AM, abdoulaye berthe wrote:
> This avoids handling gpiochip remove error in device
> remove handler.
Be aware that at the moment many callers of gpiochip_remove() read its
return value. So applying your patch as-is would break compilation.
This patch should therefore
If this step is ok I will continue by updating the codes that use it.
On Fri, May 23, 2014 at 7:12 PM, abdoulaye berthe wrote:
> This avoids handling gpiochip remove error in device
> remove handler.
>
> Signed-off-by: abdoulaye berthe
> ---
> drivers/gpio/gpiolib.c | 24 +++---
This avoids handling gpiochip remove error in device
remove handler.
Signed-off-by: abdoulaye berthe
---
drivers/gpio/gpiolib.c | 24 +++-
include/linux/gpio/driver.h | 2 +-
2 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/driver
This avoids handling gpiochip remove error in device
remove handler.
Signed-off-by: abdoulaye berthe
---
drivers/gpio/gpiolib.c | 24 +++-
include/linux/gpio/driver.h | 2 +-
2 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/driver
9 matches
Mail list logo
