Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-16 Thread Linus Walleij
On Fri, Aug 16, 2013 at 5:51 PM, Guenter Roeck wrote: > I think Michael just went on vacation. > > Clean version is below. He must have sent it to me separately > because it worked for me. Yeah this worked fine ... strange. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-16 Thread Guenter Roeck
On Fri, Aug 16, 2013 at 05:58:02PM +0200, Linus Walleij wrote: > On Fri, Aug 16, 2013 at 5:51 PM, Guenter Roeck wrote: > > > I think Michael just went on vacation. > > > > Clean version is below. He must have sent it to me separately > > because it worked for me. > > Yeah this worked fine ... st

Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-16 Thread Guenter Roeck
hand-coded it > right since it was just a oneline. > > Please try to figure out what is causing this. > Consult: > Documentation/email-clients.txt > I think Michael just went on vacation. Clean version is below. He must have sent it to me separately because it worked for me. Guenter

Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-16 Thread Linus Walleij
On Fri, Aug 9, 2013 at 5:33 PM, Michael Brunner wrote: > This patch fixes the bit masking within the GPIO driver. The masking is > basically done twice which causes the wrong GPIOs to be addressed. > > Signed-off-by: Michael Brunner This looks good but just doesn't apply. Look: git am --signof

Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-10 Thread Kevin Strasser
On Fri, Aug 09, 2013 at 05:33:26PM +0200, Michael Brunner wrote: > This patch fixes the bit masking within the GPIO driver. The masking is > basically done twice which causes the wrong GPIOs to be addressed. > > Signed-off-by: Michael Brunner Acked-by: Kevin Strasser > --- > drivers/gpio/gpio

Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-09 Thread Guenter Roeck
On Fri, Aug 09, 2013 at 05:33:26PM +0200, Michael Brunner wrote: > This patch fixes the bit masking within the GPIO driver. The masking is > basically done twice which causes the wrong GPIOs to be addressed. > > Signed-off-by: Michael Brunner Reviewed-by: Guenter Roeck > --- > drivers/gpio/gp

[PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver

2013-08-09 Thread Michael Brunner
This patch fixes the bit masking within the GPIO driver. The masking is basically done twice which causes the wrong GPIOs to be addressed. Signed-off-by: Michael Brunner --- drivers/gpio/gpio-kempld.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a