Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

2015-11-17 Thread Linus Walleij
On Wed, Nov 4, 2015 at 1:30 PM, William Breathitt Gray wrote: > To prevent confusion and to match existing coding style used in other > gpio drivers symbol names within the 104-idio-16 gpio driver should be > lowercase. > > Signed-off-by: William Breathitt Gray This patch doesn not apply on top

Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

2015-11-08 Thread Alexandre Courbot
On Mon, Nov 9, 2015 at 10:28 AM, William Breathitt Gray wrote: > On 11/08/2015 06:53 PM, Alexandre Courbot wrote: >> Apart from that this patch seems harmless and the repositioning of >> some constant declarations is also welcome. > > I'll create a separate patch to reposition the constant declara

Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

2015-11-08 Thread William Breathitt Gray
On 11/08/2015 06:53 PM, Alexandre Courbot wrote: > Apart from that this patch seems harmless and the repositioning of > some constant declarations is also welcome. I'll create a separate patch to reposition the constant declarations. Where in particular do you believe would be best for them to be

Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

2015-11-08 Thread Alexandre Courbot
On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray wrote: > To prevent confusion and to match existing coding style used in other > gpio drivers symbol names within the 104-idio-16 gpio driver should be > lowercase. ... and for the same styling reasons "GPIO" should be spelled in uppercase in

[PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

2015-11-04 Thread William Breathitt Gray
To prevent confusion and to match existing coding style used in other gpio drivers symbol names within the 104-idio-16 gpio driver should be lowercase. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idio-16.c | 31 +++ 1 file changed, 15 insertions(+)