Re: [PATCH] genirq:Dereference desc after null pointer check

2018-07-17 Thread RAGHU H
Yes Dan, I should have done better. Also Tom suggested to get rid of NULL pointer check as its redundant because callee does that before calling __free_irq. On Tue, Jul 17, 2018 at 03:25:57PM +0300, Dan Carpenter wrote: > Hi RAGHU, > > Thank you for the patch! Perhaps something to improve: > >

Re: [PATCH] genirq:Dereference desc after null pointer check

2018-07-17 Thread Dan Carpenter
Hi RAGHU, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/RAGHU-Halharvi/genirq-Dereference-desc-after-null-pointer-check/20180717-150842 smatch warnings: kernel/irq/manage.c:1571 __free_irq() error: uninitialized symbol 'irq'. # https:/

Re: [PATCH] genirq:Dereference desc after null pointer check

2018-07-17 Thread Thomas Gleixner
On Tue, 17 Jul 2018, RAGHU Halharvi wrote: > * Remove unchecked dereferencing of *desc & assigning it local irq > variable > * Move the assignement after proper check of *desc for NULL pointer. Sorry no. The NULL pointer check is pointless because the call sites already do it before calling

[PATCH] genirq:Dereference desc after null pointer check

2018-07-17 Thread RAGHU Halharvi
* Remove unchecked dereferencing of *desc & assigning it local irq variable * Move the assignement after proper check of *desc for NULL pointer. Signed-off-by: RAGHU Halharvi --- kernel/irq/manage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/irq/manag

[PATCH] genirq:Dereference desc after null pointer check

2018-07-16 Thread RAGHU Halharvi
* Remove unchecked dereferencing of *desc & assigning it local irq variable * Move the assignement after proper check of *desc for NULL pointer. Signed-off-by: RAGHU Halharvi --- kernel/irq/manage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/irq/manage.c b/kern