Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Shijith Thotton
On 7/4/19 9:19 AM, Thomas Gleixner wrote: > On Thu, 4 Jul 2019, Shijith Thotton wrote: >> On 7/4/19 12:13 AM, Julien Thierry wrote: >>> Looking at handle_percpu_irq(), I think this might be acceptable. But >>> does it make sense to only have kstats for percpu NMIs? >>> >> >> It would be better to

Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Thomas Gleixner
On Thu, 4 Jul 2019, Shijith Thotton wrote: > On 7/4/19 12:13 AM, Julien Thierry wrote: > > Looking at handle_percpu_irq(), I think this might be acceptable. But > > does it make sense to only have kstats for percpu NMIs? > > > > It would be better to have stats for both. > > handle_fasteoi_nmi()

Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Shijith Thotton
Hi Julien, On 7/4/19 12:13 AM, Julien Thierry wrote: > On 04/07/2019 05:22, Shijith Thotton wrote: >> The NMI handlers handle_percpu_devid_fasteoi_nmi() and >> handle_fasteoi_nmi() added by commit 2dcf1fbcad35 ("genirq: Provide NMI >> handlers") do not update the interrupt counts. Due to that the

Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Julien Thierry
Hi Shijith, On 04/07/2019 05:22, Shijith Thotton wrote: > The NMI handlers handle_percpu_devid_fasteoi_nmi() and > handle_fasteoi_nmi() added by commit 2dcf1fbcad35 ("genirq: Provide NMI > handlers") do not update the interrupt counts. Due to that the NMI > interrupt count does not show up correct

[PATCH] genirq: update irq stats from NMI handlers

2019-07-03 Thread Shijith Thotton
The NMI handlers handle_percpu_devid_fasteoi_nmi() and handle_fasteoi_nmi() added by commit 2dcf1fbcad35 ("genirq: Provide NMI handlers") do not update the interrupt counts. Due to that the NMI interrupt count does not show up correctly in /proc/interrupts. Update the functions to fix this. With t