Re: [PATCH] futex: Avoid wake_futex for a PI futex_q

2012-11-22 Thread Darren Hart
On 11/21/2012 02:34 PM, Andrew Morton wrote: > On Tue, 20 Nov 2012 23:36:45 -0800 > Darren Hart wrote: > >> Dave Jones reported a bug with futex_lock_pi() that his trinity test >> exposed. Sometime between queue_me() and taking the q.lock_ptr, the >> lock_ptr became NULL, resulting in a crash.

[PATCH] futex: Avoid wake_futex for a PI futex_q

2012-11-20 Thread Darren Hart
Dave Jones reported a bug with futex_lock_pi() that his trinity test exposed. Sometime between queue_me() and taking the q.lock_ptr, the lock_ptr became NULL, resulting in a crash. While futex_wake() is careful to not call wake_futex() on futex_q's with a pi_state or an rt_waiter (which are either