Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-15 Thread Sedat Dilek
On Tue, Jul 14, 2020 at 2:57 PM Sedat Dilek wrote: > > On Tue, Jul 14, 2020 at 2:53 PM Miklos Szeredi wrote: > > > > On Tue, Jul 14, 2020 at 2:40 PM Sedat Dilek wrote: > > > > > Did you sent out a new version of your patch? > > > If yes, where can I get it from? > > > > Just pushed a bunch of fi

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-14 Thread Sedat Dilek
On Tue, Jul 14, 2020 at 2:53 PM Miklos Szeredi wrote: > > On Tue, Jul 14, 2020 at 2:40 PM Sedat Dilek wrote: > > > Did you sent out a new version of your patch? > > If yes, where can I get it from? > > Just pushed a bunch of fixes including this one to > > git://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-14 Thread Miklos Szeredi
On Tue, Jul 14, 2020 at 2:40 PM Sedat Dilek wrote: > Did you sent out a new version of your patch? > If yes, where can I get it from? Just pushed a bunch of fixes including this one to git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next Thanks, Miklos

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-14 Thread Sedat Dilek
On Mon, Jul 13, 2020 at 6:16 PM Miklos Szeredi wrote: > > On Mon, Jul 13, 2020 at 10:02 AM Vasily Averin wrote: > > > > On 7/11/20 7:01 AM, Miklos Szeredi wrote: > > > On Thu, Jun 25, 2020 at 11:02 AM Vasily Averin wrote: > > >> > > >> In current implementation fuse_writepages_fill() tries to sh

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-13 Thread Vasily Averin
On 7/13/20 7:14 PM, Miklos Szeredi wrote: > On Mon, Jul 13, 2020 at 10:02 AM Vasily Averin wrote: >> >> On 7/11/20 7:01 AM, Miklos Szeredi wrote: >>> On Thu, Jun 25, 2020 at 11:02 AM Vasily Averin wrote: In current implementation fuse_writepages_fill() tries to share the code: for

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-13 Thread Miklos Szeredi
On Mon, Jul 13, 2020 at 10:02 AM Vasily Averin wrote: > > On 7/11/20 7:01 AM, Miklos Szeredi wrote: > > On Thu, Jun 25, 2020 at 11:02 AM Vasily Averin wrote: > >> > >> In current implementation fuse_writepages_fill() tries to share the code: > >> for new wpa it calls tree_insert() with num_pages

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-13 Thread Vasily Averin
On 7/11/20 7:01 AM, Miklos Szeredi wrote: > On Thu, Jun 25, 2020 at 11:02 AM Vasily Averin wrote: >> >> In current implementation fuse_writepages_fill() tries to share the code: >> for new wpa it calls tree_insert() with num_pages = 0 >> then switches to common code used non-modified num_pages >>

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-07-10 Thread Miklos Szeredi
On Thu, Jun 25, 2020 at 11:02 AM Vasily Averin wrote: > > In current implementation fuse_writepages_fill() tries to share the code: > for new wpa it calls tree_insert() with num_pages = 0 > then switches to common code used non-modified num_pages > and increments it at the very end. > > Though it

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-06-29 Thread Vivek Goyal
On Thu, Jun 25, 2020 at 12:02:53PM +0300, Vasily Averin wrote: > In current implementation fuse_writepages_fill() tries to share the code: > for new wpa it calls tree_insert() with num_pages = 0 > then switches to common code used non-modified num_pages > and increments it at the very end. > > Tho

Re: [PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-06-27 Thread Sedat Dilek
On Thu, Jun 25, 2020 at 11:52 AM Vasily Averin wrote: > > In current implementation fuse_writepages_fill() tries to share the code: > for new wpa it calls tree_insert() with num_pages = 0 > then switches to common code used non-modified num_pages > and increments it at the very end. > > Though it

[PATCH] fuse_writepages_fill() optimization to avoid WARN_ON in tree_insert

2020-06-25 Thread Vasily Averin
In current implementation fuse_writepages_fill() tries to share the code: for new wpa it calls tree_insert() with num_pages = 0 then switches to common code used non-modified num_pages and increments it at the very end. Though it triggers WARN_ON(!wpa->ia.ap.num_pages) in tree_insert() WARNING: C