Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-18 Thread Steven Rostedt
On Fri, 18 Dec 2015 11:18:58 +0100 Jiri Olsa wrote: > hi, > what's the status of this one? I cannot find it out there ;-) Yeah, I haven't gotten it through my tests yet. I was testing some upstream bug fixes to push for this -rc, and my test box HD crashed. It's definitely in the queue, but the

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-18 Thread Jiri Olsa
On Wed, Dec 02, 2015 at 04:23:50PM +0100, Jiri Olsa wrote: SNIP > > > > > > > > > > should be !ftrace_function_local_disabled(op) in here, > > > > > I passed my test with attached patch > > > > > > > > > > > > > Can you retest with this patch: > > > > > > sure, but other than the declarat

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Jiri Olsa
On Wed, Dec 02, 2015 at 10:03:46AM -0500, Steven Rostedt wrote: > On Wed, 2 Dec 2015 15:50:32 +0100 > Jiri Olsa wrote: > > > On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote: > > > On Wed, 2 Dec 2015 09:58:26 +0100 > > > Jiri Olsa wrote: > > > > > > > On Tue, Dec 01, 2015 at 11:

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Steven Rostedt
On Wed, 2 Dec 2015 15:50:32 +0100 Jiri Olsa wrote: > On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote: > > On Wed, 2 Dec 2015 09:58:26 +0100 > > Jiri Olsa wrote: > > > > > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: > > > > > > SNIP > > > > > > > -static

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Jiri Olsa
On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote: > On Wed, 2 Dec 2015 09:58:26 +0100 > Jiri Olsa wrote: > > > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: > > > > SNIP > > > > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long > > > parent_i

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Steven Rostedt
On Wed, 2 Dec 2015 09:58:26 +0100 Jiri Olsa wrote: > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: > > SNIP > > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long > > parent_ip, > > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long > > pa

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Steven Rostedt
On Wed, 2 Dec 2015 08:59:11 +0100 Jiri Olsa wrote: > > - op->func(ip, parent_ip, op, regs); > > + preempt_disable_notrace(); > > I was wondering about not disabling preemption in the original > ftrace_ops_recurs_func function.. thats why I added new one ;-) Yeah, I paused on that too. But

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-02 Thread Jiri Olsa
On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: SNIP > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long parent_ip, > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip, > struct ftrace_ops *op, struct p

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-01 Thread Jiri Olsa
On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: > On Tue, 1 Dec 2015 16:57:44 +0100 > Jiri Olsa wrote: > > > > > Hmm, I thought that I forced the list function when RCU or PER_CPU > > > was set. Oh wait. I have CONFIG_PREEMPT set, which will change the > > > logic slightly. I'm g

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-01 Thread Steven Rostedt
On Tue, 1 Dec 2015 16:57:44 +0100 Jiri Olsa wrote: > > Hmm, I thought that I forced the list function when RCU or PER_CPU > > was set. Oh wait. I have CONFIG_PREEMPT set, which will change the > > logic slightly. I'm guessing you have PREEMPT_VOLUNTARY set. I'll try > > that out. > > yep, but

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-01 Thread Jiri Olsa
On Tue, Dec 01, 2015 at 09:55:54AM -0500, Steven Rostedt wrote: > On Tue, 1 Dec 2015 14:42:36 +0100 > Jiri Olsa wrote: > > > On Mon, Nov 30, 2015 at 05:36:40PM -0500, Steven Rostedt wrote: > > > > > > [ Jiri, can you take a look at this. You can also apply it on top of my > > > branch ftrace/c

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-01 Thread Steven Rostedt
On Tue, 1 Dec 2015 14:42:36 +0100 Jiri Olsa wrote: > On Mon, Nov 30, 2015 at 05:36:40PM -0500, Steven Rostedt wrote: > > > > [ Jiri, can you take a look at this. You can also apply it on top of my > > branch ftrace/core, and run any specific tests. I just need to nuke > > that control struct

Re: [PATCH] ftrace: Remove use of control list and ops

2015-12-01 Thread Jiri Olsa
On Mon, Nov 30, 2015 at 05:36:40PM -0500, Steven Rostedt wrote: > > [ Jiri, can you take a look at this. You can also apply it on top of my > branch ftrace/core, and run any specific tests. I just need to nuke > that control structure for further updates with ftrace. ] > > > Currently perf h

[PATCH] ftrace: Remove use of control list and ops

2015-11-30 Thread Steven Rostedt
[ Jiri, can you take a look at this. You can also apply it on top of my branch ftrace/core, and run any specific tests. I just need to nuke that control structure for further updates with ftrace. ] Currently perf has its own list function within the ftrace infrastructure that seems to be use