Re: [f2fs-dev] [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-30 Thread Chao Yu
Hi Ted, On 2016/8/30 3:08, Theodore Ts'o wrote: > On Mon, Aug 29, 2016 at 10:55:47PM +0800, Chao Yu wrote: >> Hi Ted, Jaegeuk, >> >> Since encryption functionality in ext4/f2fs was exported to vfs as fscrypot >> module, more filesystems can use it, I'm not sure, maybe other fs will >> traverse >>

Re: [f2fs-dev] [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-29 Thread Theodore Ts'o
On Mon, Aug 29, 2016 at 10:55:47PM +0800, Chao Yu wrote: > Hi Ted, Jaegeuk, > > Since encryption functionality in ext4/f2fs was exported to vfs as fscrypot > module, more filesystems can use it, I'm not sure, maybe other fs will > traverse > encrypted filename directly. > > So, could we set this

Re: [f2fs-dev] [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-29 Thread Jaegeuk Kim
On Mon, Aug 29, 2016 at 10:55:47PM +0800, Chao Yu wrote: > Hi Ted, Jaegeuk, > > On 2016/8/28 14:16, Chao Yu wrote: > > Hi Ted, > > > > On 2016/8/28 13:13, Theodore Ts'o wrote: > >> On Sun, Aug 28, 2016 at 09:13:28AM +0800, Chao Yu wrote: > >>> From: Chao Yu > >>> > >>> This patch fixes to add nu

Re: [f2fs-dev] [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-29 Thread Chao Yu
Hi Ted, Jaegeuk, On 2016/8/28 14:16, Chao Yu wrote: > Hi Ted, > > On 2016/8/28 13:13, Theodore Ts'o wrote: >> On Sun, Aug 28, 2016 at 09:13:28AM +0800, Chao Yu wrote: >>> From: Chao Yu >>> >>> This patch fixes to add null character at the end of encrypted filename Since encryption functionality

Re: [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-27 Thread Chao Yu
Hi Ted, On 2016/8/28 13:13, Theodore Ts'o wrote: > On Sun, Aug 28, 2016 at 09:13:28AM +0800, Chao Yu wrote: >> From: Chao Yu >> >> This patch fixes to add null character at the end of encrypted filename >> in fname_encrypt, in order to avoid incorrectly traversing random data >> located after tar

Re: [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-27 Thread Theodore Ts'o
On Sun, Aug 28, 2016 at 09:13:28AM +0800, Chao Yu wrote: > From: Chao Yu > > This patch fixes to add null character at the end of encrypted filename > in fname_encrypt, in order to avoid incorrectly traversing random data > located after target filename. The call stack is as below: > > - f2fs_ad

[PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt

2016-08-27 Thread Chao Yu
From: Chao Yu This patch fixes to add null character at the end of encrypted filename in fname_encrypt, in order to avoid incorrectly traversing random data located after target filename. The call stack is as below: - f2fs_add_link - __f2fs_add_link - fscrypt_setup_filename - fscrypt_fname