Re: [PATCH] fs: proc: move linux_proc_banner to where it is used

2018-11-05 Thread Masahiro Yamada
On Tue, Oct 30, 2018 at 5:18 PM Rasmus Villemoes wrote: > > On 2018-10-27 21:47, Alexey Dobriyan wrote: > > On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote: > >> +#include > > > >> +#define linux_proc_banner \ > >> +"%s version %s" \ > >> +" (" LINUX_COMPILE_BY "@" LINUX_

Re: [PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-30 Thread Rasmus Villemoes
On 2018-10-27 21:47, Alexey Dobriyan wrote: > On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote: >> +#include > >> +#define linux_proc_banner \ >> +"%s version %s" \ >> +" (" LINUX_COMPILE_BY "@" LINUX_COMPILE_HOST ")" \ >> +" (" LINUX_COMPILER ") %s\n" > > Include doe

Re: [PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-27 Thread Alexey Dobriyan
On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote: > +#include > +#define linux_proc_banner \ > + "%s version %s" \ > + " (" LINUX_COMPILE_BY "@" LINUX_COMPILE_HOST ")" \ > + " (" LINUX_COMPILER ") %s\n" Include doesn't work if compiling from scratch: rm -rf .

[PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-26 Thread Rasmus Villemoes
With -Wformat-literal, gcc complains fs/proc/version.c:11:16: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] seq_printf(m, linux_proc_banner, linux_proc_banner is only used in this one place, so move the definition here, to allow the compiler to complain