Re: [PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Andrew Morton
On Mon, 05 Mar 2007 17:10:11 -0600 Dave Kleikamp <[EMAIL PROTECTED]> wrote: > On Mon, 2007-03-05 at 14:57 -0800, Andrew Morton wrote: > > Is OK, I think. nobh_prepare_write() brings the outside-from-and-to > > sections of the page uptodate and memset in nobh_truncate_page() brings the > > rest of

Re: [PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Dave Kleikamp
On Mon, 2007-03-05 at 14:57 -0800, Andrew Morton wrote: > Is OK, I think. nobh_prepare_write() brings the outside-from-and-to > sections of the page uptodate and memset in nobh_truncate_page() brings the > rest of the page uptodate. > > We bring the to->PAGE_CACHE_SIZE section uptodate twice, whi

Re: [PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Andrew Morton
On Mon, 5 Mar 2007 13:43:03 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Mon, 5 Mar 2007, Dave Kleikamp wrote: > > > > This fixes a regression caused by 22c8ca78f20724676b6006232bf06cc3e9299539. > > > > nobh_prepare_write() no longer marks the page uptodate, so > > nobh_trunc

Re: [PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Dave Kleikamp
On Mon, 2007-03-05 at 13:43 -0800, Linus Torvalds wrote: > > On Mon, 5 Mar 2007, Dave Kleikamp wrote: > > > > This fixes a regression caused by 22c8ca78f20724676b6006232bf06cc3e9299539. > > > > nobh_prepare_write() no longer marks the page uptodate, so > > nobh_truncate_page() needs to do it. >

Re: [PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Linus Torvalds
On Mon, 5 Mar 2007, Dave Kleikamp wrote: > > This fixes a regression caused by 22c8ca78f20724676b6006232bf06cc3e9299539. > > nobh_prepare_write() no longer marks the page uptodate, so > nobh_truncate_page() needs to do it. I'm not convinced... If the page wasn't up-to-date from before, it's *

[PATCH] fs: nobh_truncate_page() fix

2007-03-05 Thread Dave Kleikamp
Adding Linus and Andrew since this patch looks obviously correct and Will and Nick are in another timezone. On Mon, 2007-03-05 at 09:50 -0600, Dave Kleikamp wrote: > On Mon, 2007-03-05 at 09:36 -0600, Dave Kleikamp wrote: > > On Mon, 2007-03-05 at 09:59 -0500, Chuck Ebbert wrote: > > > Will Trives