Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

2017-10-24 Thread Greg Edwards
On Tue, Oct 24, 2017 at 09:46:15AM +0200, Christoph Hellwig wrote: > On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote: >>> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and >>> partitions index") >>> Signed-off-by: Greg Edwards >> >> That smells like a nasty source of

Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

2017-10-24 Thread Christoph Hellwig
On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote: > > Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and > > partitions index") > > Signed-off-by: Greg Edwards > > That smells like a nasty source of overhead, especially on SMP boxen... We could just use __disk_get_pa

Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

2017-10-23 Thread Al Viro
On Mon, Oct 23, 2017 at 07:10:07PM -0600, Greg Edwards wrote: > guard_bio_eod() needs to look at the partition capacity, not just the > capacity of the whole device, when determining if truncation is > necessary. > > [ 60.268688] attempt to access beyond end of device > [ 60.268690] unknown-bl

[PATCH] fs: guard_bio_eod() needs to consider partitions

2017-10-23 Thread Greg Edwards
guard_bio_eod() needs to look at the partition capacity, not just the capacity of the whole device, when determining if truncation is necessary. [ 60.268688] attempt to access beyond end of device [ 60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506 [ 60.268693] buffer_io_err