Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Theodore Ts'o
On Sat, Oct 21, 2017 at 03:39:47PM +0200, Nicolas Belouin wrote: > Fix an issue making trusted xattr world readable and other > cap_sys_admin only > NACK. It is *documented* that trusted xattrs are only supposed to be readable by root. - Ted

Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Nicolas Belouin
Indeed, I was mistaken here. Thanks for the review. I will do the "strncmp() ==0" in another patch as it is particularly unclear in this context. On October 21, 2017 9:48:16 PM GMT+02:00, Andreas Dilger wrote: >On Oct 21, 2017, at 7:39 AM, Nicolas Belouin >wrote: >> >> Fix an issue making tru

Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Andreas Dilger
On Oct 21, 2017, at 7:39 AM, Nicolas Belouin wrote: > > Fix an issue making trusted xattr world readable and other > cap_sys_admin only > > Signed-off-by: Nicolas Belouin > --- > fs/hfsplus/xattr.c | 2 +- > fs/jfs/xattr.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > dif

[PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Nicolas Belouin
Fix an issue making trusted xattr world readable and other cap_sys_admin only Signed-off-by: Nicolas Belouin --- fs/hfsplus/xattr.c | 2 +- fs/jfs/xattr.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index d37bb88dc746..ae0