Re: [PATCH] fs: avoid fdput() after failed fdget() in vfs_dedupe_file_range()

2018-04-14 Thread Al Viro
On Sat, Apr 14, 2018 at 01:16:58AM -0500, Zev Weiss wrote: > It's a fairly inconsequential bug, since fdput() won't actually try to > fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in > the failure case, but most other vfs code takes steps to avoid this. Applied.

[PATCH] fs: avoid fdput() after failed fdget() in vfs_dedupe_file_range()

2018-04-13 Thread Zev Weiss
It's a fairly inconsequential bug, since fdput() won't actually try to fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in the failure case, but most other vfs code takes steps to avoid this. Signed-off-by: Zev Weiss --- fs/read_write.c | 6 +++--- 1 file changed, 3 insertions(+)