Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-15 Thread Mel Gorman
On Fri, Jun 12, 2020 at 11:34:16PM +0300, Amir Goldstein wrote: > > > > So maybe it would be better to list all users of alloc_file_pseudo() > > > > and say that they all should be opted out of fsnotify, without > > > > mentioning > > > > "internal mount"? > > > > > > > > > > The users are DMA buf

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-15 Thread Amir Goldstein
On Mon, Jun 15, 2020 at 11:12 AM Jan Kara wrote: > > On Fri 12-06-20 23:34:16, Amir Goldstein wrote: > > > > > So maybe it would be better to list all users of alloc_file_pseudo() > > > > > and say that they all should be opted out of fsnotify, without > > > > > mentioning > > > > > "internal mou

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-15 Thread Jan Kara
On Fri 12-06-20 23:34:16, Amir Goldstein wrote: > > > > So maybe it would be better to list all users of alloc_file_pseudo() > > > > and say that they all should be opted out of fsnotify, without > > > > mentioning > > > > "internal mount"? > > > > > > > > > > The users are DMA buffers, CXL, aio,

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-12 Thread Amir Goldstein
> > > So maybe it would be better to list all users of alloc_file_pseudo() > > > and say that they all should be opted out of fsnotify, without mentioning > > > "internal mount"? > > > > > > > The users are DMA buffers, CXL, aio, anon inodes, hugetlbfs, anonymous > > pipes, shmem and sockets althou

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-12 Thread Amir Goldstein
On Fri, Jun 12, 2020 at 4:18 PM Mel Gorman wrote: > > On Fri, Jun 12, 2020 at 12:52:28PM +0300, Amir Goldstein wrote: > > On Fri, Jun 12, 2020 at 12:26 PM Mel Gorman > > wrote: > > > > > > The kernel uses internal mounts for a number of purposes including pipes. > > > On every vfs_write regardle

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-12 Thread Mel Gorman
On Fri, Jun 12, 2020 at 12:52:28PM +0300, Amir Goldstein wrote: > On Fri, Jun 12, 2020 at 12:26 PM Mel Gorman > wrote: > > > > The kernel uses internal mounts for a number of purposes including pipes. > > On every vfs_write regardless of filesystem, fsnotify_modify() is called > > to notify of an

Re: [PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-12 Thread Amir Goldstein
On Fri, Jun 12, 2020 at 12:26 PM Mel Gorman wrote: > > The kernel uses internal mounts for a number of purposes including pipes. > On every vfs_write regardless of filesystem, fsnotify_modify() is called > to notify of any changes which incurs a small amount of overhead in fsnotify > even when the

[PATCH] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-12 Thread Mel Gorman
The kernel uses internal mounts for a number of purposes including pipes. On every vfs_write regardless of filesystem, fsnotify_modify() is called to notify of any changes which incurs a small amount of overhead in fsnotify even when there are no watchers. A patch is pending that reduces, but does