RE: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-16 Thread Luck, Tony
> I swear this had been fixed before. Thanks for catching it! Maybe I missed it? > Acked-by: Kees Cook Got it this time - should show up in the next linux-next build. Thanks -Tony

Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-13 Thread Kees Cook
On Mon, Mar 9, 2015 at 12:39 AM, Wang Long wrote: > In the function ramoops_probe, the console_size, pmsg_size, > ftrace_size may be update because the value is not the power > of two. We should update the module parameter variables > as well so they are visible through /sys/module/ramoops/paramet

Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-09 Thread Mark Salyzyn
On 03/09/2015 04:17 AM, long.wanglong wrote: In the function ramoops_probe, the console_size, pmsg_size, ftrace_size may be update because the value is not the power of two. We should update the module parameter variables as well so they are visible through /sys/module/ramoops/parameters correctl

Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-09 Thread long.wanglong
On 2015/3/9 15:39, Wang Long wrote: cc: marco.storne...@gmail.com cc: anton.voront...@linaro.org cc: saly...@android.com cc: ser...@chromium.org > In the function ramoops_probe, the console_size, pmsg_size, > ftrace_size may be update because the value is not the power > of two. We should update t

[PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-09 Thread Wang Long
In the function ramoops_probe, the console_size, pmsg_size, ftrace_size may be update because the value is not the power of two. We should update the module parameter variables as well so they are visible through /sys/module/ramoops/parameters correctly. Signed-off-by: Wang Long --- fs/pstore/ra