RE: [PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread Nixiaoming
On Mon, Jul 23, 2018 at 3:08 AM, Trond Myklebust wrote: >On Sun, 2018-07-22 at 15:01 -0400, Chuck Lever wrote: >> > On Jul 22, 2018, at 2:33 PM, Trond Myklebust < >> > tron...@hammerspace.com> wrote: >> > >> > On Sun, 2018-07-22 at 14:12 -0400, Chuck Lever wrote: >> > > > On Jul 22, 2018, at 4:50

Re: [PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread Trond Myklebust
On Sun, 2018-07-22 at 15:01 -0400, Chuck Lever wrote: > > On Jul 22, 2018, at 2:33 PM, Trond Myklebust < > > tron...@hammerspace.com> wrote: > > > > On Sun, 2018-07-22 at 14:12 -0400, Chuck Lever wrote: > > > > On Jul 22, 2018, at 4:50 AM, nixiaoming > > > > wrote: > > > > > > > > dummy = be32_t

Re: [PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread Chuck Lever
> On Jul 22, 2018, at 2:33 PM, Trond Myklebust wrote: > > On Sun, 2018-07-22 at 14:12 -0400, Chuck Lever wrote: >>> On Jul 22, 2018, at 4:50 AM, nixiaoming >>> wrote: >>> >>> dummy = be32_to_cpup(p++); >>> dummy = be32_to_cpup(p++); >>> Assigning value to "dummy" here, but that stored value

Re: [PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread Trond Myklebust
On Sun, 2018-07-22 at 14:12 -0400, Chuck Lever wrote: > > On Jul 22, 2018, at 4:50 AM, nixiaoming > > wrote: > > > > dummy = be32_to_cpup(p++); > > dummy = be32_to_cpup(p++); > > Assigning value to "dummy" here, but that stored value > > is overwritten before it can be used. > > > > delete inval

Re: [PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread Chuck Lever
> On Jul 22, 2018, at 4:50 AM, nixiaoming wrote: > > dummy = be32_to_cpup(p++); > dummy = be32_to_cpup(p++); > Assigning value to "dummy" here, but that stored value > is overwritten before it can be used. > > delete invalid assignment statements in nfsd4_decode_exchange_id > > Signed-off-by

[PATCH] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id

2018-07-22 Thread nixiaoming
dummy = be32_to_cpup(p++); dummy = be32_to_cpup(p++); Assigning value to "dummy" here, but that stored value is overwritten before it can be used. delete invalid assignment statements in nfsd4_decode_exchange_id Signed-off-by: n00202754 --- fs/nfsd/nfs4xdr.c | 4 ++-- 1 file changed, 2 insertio