Re: [PATCH] fs/file.c: don't acquire files->file_lock in fd_install()

2015-04-28 Thread Eric Dumazet
On Mon, 2015-04-27 at 21:05 +0200, Mateusz Guzik wrote: > On Tue, Apr 21, 2015 at 09:59:28PM -0700, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Mateusz Guzik reported : > > > > Currently obtaining a new file descriptor results in locking fdtable > > twice - once in order to reserve a sl

Re: [PATCH] fs/file.c: don't acquire files->file_lock in fd_install()

2015-04-27 Thread Mateusz Guzik
On Tue, Apr 21, 2015 at 09:59:28PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Mateusz Guzik reported : > > Currently obtaining a new file descriptor results in locking fdtable > twice - once in order to reserve a slot and second time to fill it. > > Holding the spinlock in __fd_insta

[PATCH] fs/file.c: don't acquire files->file_lock in fd_install()

2015-04-21 Thread Eric Dumazet
From: Eric Dumazet Mateusz Guzik reported : Currently obtaining a new file descriptor results in locking fdtable twice - once in order to reserve a slot and second time to fill it. Holding the spinlock in __fd_install() is needed in case a resize is done, or to prevent a resize. Mateusz prov