Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread linux-os (Dick Johnson)
On Wed, 13 Feb 2008, [iso-8859-1] Ilpo Järvinen wrote: > On Wed, 13 Feb 2008, linux-os (Dick Johnson) wrote: >> >> On Wed, 13 Feb 2008, [iso-8859-1] Ilpo Järvinen wrote: >> >>> They're defined later on in the same file with bodies and >>> nothingin between needs them. >>> >>> Signed-off-by: Ilpo

Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Pekka Enberg
On Feb 13, 2008 3:43 PM, linux-os (Dick Johnson) <[EMAIL PROTECTED]> wrote: > You should not remove things just because you don't think they > are necessary. They do no harm and removing them can cause > code checking tools to issue diagnostic messages. Err, no, Ilpo's patch looks good and the red

Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Jan Harkes
On Wed, Feb 13, 2008 at 02:22:43PM +0200, Ilpo J?rvinen wrote: > They're defined later on in the same file with bodies and > nothingin between needs them. > > Signed-off-by: Ilpo J?rvinen <[EMAIL PROTECTED]> Acked-by: Jan Harkes <[EMAIL PROTECTED]> Looks good, getting rid of such cruft is always

Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Ilpo Järvinen
On Wed, 13 Feb 2008, linux-os (Dick Johnson) wrote: > > On Wed, 13 Feb 2008, [iso-8859-1] Ilpo Järvinen wrote: > > > They're defined later on in the same file with bodies and > > nothingin between needs them. > > > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > > --- > > include/linux/coda_

Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread linux-os (Dick Johnson)
On Wed, 13 Feb 2008, [iso-8859-1] Ilpo Järvinen wrote: > They're defined later on in the same file with bodies and > nothingin between needs them. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > --- > include/linux/coda_linux.h |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-)

[PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Ilpo Järvinen
They're defined later on in the same file with bodies and nothingin between needs them. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/coda_linux.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/coda_linux.h b/include/linux/coda_linux.