Re: [PATCH] fs/buffer.c: grow_buffers: fix the uncorrect check

On Sat, May 31, 2014 at 11:12 AM, mnipxh wrote: > When pgoff_t index is 32bit, sector_t block is 64bit, need check if block > number is too big. > If block is bigger than (4Gb * PAGE_SIZE), index becomes a wrong value. > Commit e5657933863f43cc6bb76a54d659303dafaa9e58 wants to do this. But it >

[PATCH] fs/buffer.c: grow_buffers: fix the uncorrect check

When pgoff_t index is 32bit, sector_t block is 64bit, need check if block number is too big. If block is bigger than (4Gb * PAGE_SIZE), index becomes a wrong value. Commit e5657933863f43cc6bb76a54d659303dafaa9e58 wants to do this. But it gives an uncorrect check. I think block != index << sizebit