Re: [PATCH] fs/buffer: simplify the code flow of LRU management algorithm

2015-10-09 Thread Minfei Huang
On 09/28/15 at 02:52pm, yalin wang wrote: > why not change like this: > > diff --git a/fs/buffer.c b/fs/buffer.c > index 82283ab..d6769f1 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -1287,40 +1287,31 @@ static inline void check_irqs_on(void) > */ > static void bh_lru_install(struct buff

Re: [PATCH] fs/buffer: simplify the code flow of LRU management algorithm

2015-09-27 Thread yalin wang
why not change like this: diff --git a/fs/buffer.c b/fs/buffer.c index 82283ab..d6769f1 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1287,40 +1287,31 @@ static inline void check_irqs_on(void) */ static void bh_lru_install(struct buffer_head *bh) { - struct buffer_head *evictee = NULL;

Re: [PATCH] fs/buffer: simplify the code flow of LRU management algorithm

2015-09-27 Thread Minfei Huang
Ping, Could you someone help to review this patch? Thanks Minfei On 09/10/15 at 04:09pm, Minfei Huang wrote: > From: Minfei Huang > > There is a buffer_head lru list cache in local cpu to accelerate the > speed. The LRU management algorithm is simple enough in > bh_lru_install(). > > There are

[PATCH] fs/buffer: simplify the code flow of LRU management algorithm

2015-09-10 Thread Minfei Huang
From: Minfei Huang There is a buffer_head lru list cache in local cpu to accelerate the speed. The LRU management algorithm is simple enough in bh_lru_install(). There are three situtaions we should deal with. 1) All/part of the lru cache is NULL. 2) The new buffer_head hitts the lru cache. 3) T