Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-09-14 Thread Greg Ungerer
Hi Rich, On 15/09/15 01:17, Rich Felker wrote: > On Mon, Sep 14, 2015 at 10:13:03PM +1000, Greg Ungerer wrote: >> On 26/08/15 11:26, Greg Ungerer wrote: >>> On 21/08/15 05:11, Rich Felker wrote: From: Rich Felker On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to

Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-09-14 Thread Rich Felker
On Mon, Sep 14, 2015 at 10:13:03PM +1000, Greg Ungerer wrote: > Hi Rich, > > > On 26/08/15 11:26, Greg Ungerer wrote: > >On 21/08/15 05:11, Rich Felker wrote: > >>From: Rich Felker > >> > >>On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to > >>overlap with all but the last PAG

Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-09-14 Thread Greg Ungerer
Hi Rich, On 26/08/15 11:26, Greg Ungerer wrote: On 21/08/15 05:11, Rich Felker wrote: From: Rich Felker On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to overlap with all but the last PAGE_SIZE bytes of the stack. This leads to catastrophic memory reuse/corruption if brk i

Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-09-10 Thread David Howells
Greg Ungerer wrote: > It would make sense to run this by David Howells , > I think he wrote this code (added to CC list). > > I have no problem with it, so: Fine by me too. Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-08-25 Thread Rich Felker
On Wed, Aug 26, 2015 at 11:26:02AM +1000, Greg Ungerer wrote: > Hi Rich, > > On 21/08/15 05:11, Rich Felker wrote: > > From: Rich Felker > > > > On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to > > overlap with all but the last PAGE_SIZE bytes of the stack. This leads > > to

Re: [PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-08-25 Thread Greg Ungerer
Hi Rich, On 21/08/15 05:11, Rich Felker wrote: > From: Rich Felker > > On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to > overlap with all but the last PAGE_SIZE bytes of the stack. This leads > to catastrophic memory reuse/corruption if brk is used. Fix by setting > the brk

[PATCH] fs/binfmt_elf_fdpic.c: fix brk area overlap with stack on NOMMU

2015-08-20 Thread Rich Felker
From: Rich Felker On NOMMU archs, the FDPIC ELF loader sets up the usable brk range to overlap with all but the last PAGE_SIZE bytes of the stack. This leads to catastrophic memory reuse/corruption if brk is used. Fix by setting the brk area to zero size to disable its use. Signed-off-by: Rich F