Re: [PATCH] freezer: fix freeze timeout on exec

2018-11-11 Thread kbuild test robot
Hi Chanho, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] freezer: fix freeze timeout on exec

2018-11-11 Thread kbuild test robot
Hi Chanho, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

RE: [PATCH] freezer: fix freeze timeout on exec

2018-11-08 Thread Chanho Min
> > > > Can't we simply change de_thread() to use freezable_schedule() ? > > > > Oleg. > > We need to change freezable_schedule_timeout() instead. > freezable_schedule also can't be frozen if sub-threads can't stop > schedule(). > Furthermore, I'm not sure if it is safe to freeze it at de_thread()

RE: [PATCH] freezer: fix freeze timeout on exec

2018-11-08 Thread Chanho Min
> > > > To fix this, I suggest a patch by emboding the mentioned solution. > > First, revive and rework cancel_freezing_and_thaw() function whitch > > stops the task from sleeping in refrigirator reliably. And, The task > > to be killed does not allow to freeze. > > Can't we simply change de_threa

Re: [PATCH] freezer: fix freeze timeout on exec

2018-11-08 Thread Oleg Nesterov
On 11/08, Chanho Min wrote: > > Suspend fails due to the exec family of fuctnions blocking the freezer. > This issue has been found that it is mentioned in the ancient mail thread. > The casue is that de_thread() sleeps in TASK_UNINTERRUPTIBLE waiting for all > sub-threads to die, and we have the "

[PATCH] freezer: fix freeze timeout on exec

2018-11-08 Thread Chanho Min
Suspend fails due to the exec family of fuctnions blocking the freezer. This issue has been found that it is mentioned in the ancient mail thread. The casue is that de_thread() sleeps in TASK_UNINTERRUPTIBLE waiting for all sub-threads to die, and we have the "deadlock" if one of them is frozen. It