Re: [PATCH] for_each macros correctness

2014-01-28 Thread Heiko Carstens
On Sun, Jan 26, 2014 at 08:54:18AM -0200, Jose Alonso wrote: > > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a pa

Re: [PATCH] for_each macros correctness

2014-01-27 Thread Jens Axboe
On Sun, Jan 26 2014, Jose Alonso wrote: > > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a page and the next page

RE: [PATCH] for_each macros correctness

2014-01-27 Thread Dorau, Lukasz
On Sunday, January 26, 2014 11:54 AM Jose Alonso wrote: > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a page and

Re: [PATCH] for_each macros correctness

2014-01-26 Thread Jose Alonso
On Sun, 2014-01-26 at 14:39 +0100, Fubo Chen wrote: > On Sun, Jan 26, 2014 at 11:54 AM, Jose Alonso wrote: > > I observed that there are for_each macros that do an extra memory access > > beyond the defined area. > > Normally this does not cause problems. > > But, this can cause exceptions. For ex

Re: [PATCH] for_each macros correctness

2014-01-26 Thread Fubo Chen
On Sun, Jan 26, 2014 at 11:54 AM, Jose Alonso wrote: > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a page and the

[PATCH] for_each macros correctness

2014-01-26 Thread Jose Alonso
I observed that there are for_each macros that do an extra memory access beyond the defined area. Normally this does not cause problems. But, this can cause exceptions. For example: if the area is allocated at the end of a page and the next page is not accessible. For correctness, I suggest chang